Hmm, I committed my outstanding PR with no conflicts, so I assume you didn't get the reformatting in yet; let me know if *I* can help :)
-MIke On Tue, Dec 22, 2020 at 9:06 AM Michael Sokolov <[email protected]> wrote: > > Thanks for the heads up. If you commit your changes first, I'll tackle the > reformatting and let you know if I run into issues. Looks as if javadoc is > likely to be the main challenge? > > On Tue, Dec 22, 2020, 8:56 AM Dawid Weiss <[email protected]> wrote: >> >> Hi Mike, Ignacio, >> >> Just wanted to let you know that I wanted to go through the rest of >> lucene-core reformatting soon-ish (I've done a lot on the branch >> already and a subset of packages ended on master too). >> >> This will touch packages which you've been working on recently. I >> don't think it'll be a problem, even if you have active modifications >> you're working on, although it may require a bit of manual juggling. >> >> In short, the process is fairly simple - get up-to-date >> spotless.gradle on to your branch (from master), then reformat the >> code on your branch and commit it. git should be smart enough to >> figure out the differences between your branch and master (after >> reformatting) - and these differences should be in your modified code >> only. >> >> Let me know if you need me to do this directly on any of your branches >> and I'll be happy to help. >> >> Dawid --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
