No, you'll have to get used to it (and you will, I guarantee you). > What is “+” and “-“?
Unified diff markers. They're helpful but they're just explanations - why would you care, run gradlew tidy and continue working. D. On Thu, Jan 7, 2021 at 2:02 PM Michael Sokolov <[email protected]> wrote: > I tend to agree that the line width spotless uses is too narrow for my > taste, but I guess it is not configurable, and I still prefer some standard > over the mishmash we had before. > > On Thu, Jan 7, 2021 at 6:36 AM Uwe Schindler <[email protected]> wrote: > >> Ah thanks, now this explains. 😊 >> >> >> >> In the meantime, I have also seen the hard failures (red builds) on >> Policeman Jenkins! >> >> >> >> Question: Reading the log output: the diff supplied is a bit unclear: >> >> What is “+” and “-“? This should be written on top, to allow the >> developer to understand what’s wrong: Should the code look like “+” or >> should the code look like “-“? >> >> >> >> To my personal style, the “one-liners” are much better readable to me, so >> splitting the lines is just horrible and I would never write code like that >> ☹ >> >> >> >> Uwe >> >> >> >> ----- >> >> Uwe Schindler >> >> Achterdiek 19, D-28357 Bremen >> >> https://www.thetaphi.de >> >> eMail: [email protected] >> >> >> >> *From:* Dawid Weiss <[email protected]> >> *Sent:* Thursday, January 7, 2021 12:17 PM >> *To:* Lucene Dev <[email protected]> >> *Subject:* Re: [JENKINS-EA] Lucene-Solr-jdk16panama-Linux >> (64bit/jdk-16-ea+30) - Build # 11 - Still Unstable! >> >> >> >> >> >> Hmm... I might have provided the wrong link - the correct fail is here, >> for example: >> >> >> >> >> https://ci-builds.apache.org/job/Lucene/job/Lucene-Solr-Check-master/1327/consoleText >> >> >> >> FAILURE: Build failed with an exception. >> >> >> >> * What went wrong: >> >> Execution failed for task ':lucene:test-framework:spotlessJavaCheck'. >> >> > The following files had format violations: >> >> >> lucene/test-framework/src/java/org/apache/lucene/store/BaseDirectoryTestCase.java >> >> @@ -281,14 +281,14 @@ >> >> ······final·int·offset·=·random().nextInt(4); >> >> ······final·int·length·=·TestUtil.nextInt(random(),·1,·16); >> >> >> ······try·(IndexOutput·out·=·dir.createOutput("Floats",·newIOContext(random())))·{ >> >> >> -········byte[]·b·=·new·byte[offset·+·length·*·Float.BYTES·-·TestUtil.nextInt(random(),·1,·Float.BYTES)]; >> >> +········byte[]·b·= >> >> >> +············new·byte[offset·+·length·*·Float.BYTES·-·TestUtil.nextInt(random(),·1,·Float.BYTES)]; >> >> ········random().nextBytes(b); >> >> ········out.writeBytes(b,·b.length); >> >> ······} >> >> >> ······try·(IndexInput·input·=·dir.openInput("Floats",·newIOContext(random())))·{ >> >> ········input.seek(offset); >> >> -········expectThrows(EOFException.class, >> >> >> -············()·->·input.readLEFloats(new·float[length],·0,·length)); >> >> >> +········expectThrows(EOFException.class,·()·->·input.readLEFloats(new·float[length],·0,·length)); >> >> ······} >> >> ····} >> >> ··} >> >> Run './gradlew :lucene:test-framework:spotlessApply' to fix these >> violations. >> >> >> >> >> >> On Thu, Jan 7, 2021 at 11:48 AM Uwe Schindler <[email protected]> wrote: >> >> Hi, >> >> >> >> I am a bit confused by this mail: “Lucene-Solr-jdk16panama-Linux” Jenkins >> jobs only run „gradlew test -Dtests.directory=MMapDirectory” nothing else!? >> >> >> >> Uwe >> >> >> >> ----- >> >> Uwe Schindler >> >> Achterdiek 19, D-28357 Bremen >> >> https://www.thetaphi.de >> >> eMail: [email protected] >> >> >> >> *From:* Dawid Weiss <[email protected]> >> *Sent:* Thursday, January 7, 2021 11:00 AM >> *To:* Lucene Dev <[email protected]>; Michael Sokolov < >> [email protected]> >> *Subject:* Re: [JENKINS-EA] Lucene-Solr-jdk16panama-Linux >> (64bit/jdk-16-ea+30) - Build # 11 - Still Unstable! >> >> >> >> >> >> I think I see why you missed it -- spotless is not currently attached to >> precommit. I filed an issue to improve this situation. >> >> https://issues.apache.org/jira/browse/LUCENE-9658 >> >> >> >> I've tidied up the code and committed it for you. >> >> >> >> Dawid >> >> >> >> >> >> Dawid >> >> >> >> On Thu, Jan 7, 2021 at 10:47 AM Dawid Weiss <[email protected]> >> wrote: >> >> >> >> Hi Mike! The master branch doesn't validate because of code formatting >> violation. Please fix by running: >> >> >> >> gradlew tidy >> >> >> >> and then committing the change. In general just run tidy before >> committing anything back to ensure >> >> consistent formatting. >> >> >> >> Dawid >> >> >> >> On Thu, Jan 7, 2021 at 7:16 AM Policeman Jenkins Server < >> [email protected]> wrote: >> >> Build: https://jenkins.thetaphi.de/job/Lucene-Solr-jdk16panama-Linux/11/ >> Java: 64bit/jdk-16-ea+30 -XX:-UseCompressedOops -XX:+UseG1GC >> >> 2 tests failed. >> FAILED: org.apache.solr.handler.TestContainerPlugin.testApi >> >> Error Message: >> java.lang.AssertionError: startCalled >> >> Stack Trace: >> java.lang.AssertionError: startCalled >> at >> __randomizedtesting.SeedInfo.seed([FCADEFDBF14367CB:9D3F810996B58487]:0) >> at org.junit.Assert.fail(Assert.java:89) >> at org.junit.Assert.assertTrue(Assert.java:42) >> at >> org.apache.solr.handler.TestContainerPlugin.testApi(TestContainerPlugin.java:189) >> at >> java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native >> Method) >> at >> java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:78) >> at >> java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) >> at java.base/java.lang.reflect.Method.invoke(Method.java:567) >> at >> com.carrotsearch.randomizedtesting.RandomizedRunner.invoke(RandomizedRunner.java:1754) >> at >> com.carrotsearch.randomizedtesting.RandomizedRunner$8.evaluate(RandomizedRunner.java:942) >> at >> com.carrotsearch.randomizedtesting.RandomizedRunner$9.evaluate(RandomizedRunner.java:978) >> at >> com.carrotsearch.randomizedtesting.RandomizedRunner$10.evaluate(RandomizedRunner.java:992) >> at >> com.carrotsearch.randomizedtesting.rules.SystemPropertiesRestoreRule$1.evaluate(SystemPropertiesRestoreRule.java:57) >> at org.junit.rules.RunRules.evaluate(RunRules.java:20) >> at >> org.apache.lucene.util.TestRuleSetupTeardownChained$1.evaluate(TestRuleSetupTeardownChained.java:44) >> at >> org.apache.lucene.util.AbstractBeforeAfterRule$1.evaluate(AbstractBeforeAfterRule.java:43) >> at >> org.apache.lucene.util.TestRuleThreadAndTestName$1.evaluate(TestRuleThreadAndTestName.java:45) >> at >> org.apache.lucene.util.TestRuleIgnoreAfterMaxFailures$1.evaluate(TestRuleIgnoreAfterMaxFailures.java:60) >> at >> org.apache.lucene.util.TestRuleMarkFailure$1.evaluate(TestRuleMarkFailure.java:44) >> at org.junit.rules.RunRules.evaluate(RunRules.java:20) >> at >> com.carrotsearch.randomizedtesting.rules.StatementAdapter.evaluate(StatementAdapter.java:36) >> at >> com.carrotsearch.randomizedtesting.ThreadLeakControl$StatementRunner.run(ThreadLeakControl.java:370) >> at >> com.carrotsearch.randomizedtesting.ThreadLeakControl.forkTimeoutingTask(ThreadLeakControl.java:819) >> at >> com.carrotsearch.randomizedtesting.ThreadLeakControl$3.evaluate(ThreadLeakControl.java:470) >> at >> com.carrotsearch.randomizedtesting.RandomizedRunner.runSingleTest(RandomizedRunner.java:951) >> at >> com.carrotsearch.randomizedtesting.RandomizedRunner$5.evaluate(RandomizedRunner.java:836) >> at >> com.carrotsearch.randomizedtesting.RandomizedRunner$6.evaluate(RandomizedRunner.java:887) >> at >> com.carrotsearch.randomizedtesting.RandomizedRunner$7.evaluate(RandomizedRunner.java:898) >> at >> com.carrotsearch.randomizedtesting.rules.StatementAdapter.evaluate(StatementAdapter.java:36) >> at >> com.carrotsearch.randomizedtesting.rules.SystemPropertiesRestoreRule$1.evaluate(SystemPropertiesRestoreRule.java:57) >> at org.junit.rules.RunRules.evaluate(RunRules.java:20) >> at >> org.apache.lucene.util.AbstractBeforeAfterRule$1.evaluate(AbstractBeforeAfterRule.java:43) >> at >> com.carrotsearch.randomizedtesting.rules.StatementAdapter.evaluate(StatementAdapter.java:36) >> at >> org.apache.lucene.util.TestRuleStoreClassName$1.evaluate(TestRuleStoreClassName.java:38) >> at >> com.carrotsearch.randomizedtesting.rules.NoShadowingOrOverridesOnMethodsRule$1.evaluate(NoShadowingOrOverridesOnMethodsRule.java:40) >> at >> com.carrotsearch.randomizedtesting.rules.NoShadowingOrOverridesOnMethodsRule$1.evaluate(NoShadowingOrOverridesOnMethodsRule.java:40) >> at >> com.carrotsearch.randomizedtesting.rules.StatementAdapter.evaluate(StatementAdapter.java:36) >> at >> com.carrotsearch.randomizedtesting.rules.StatementAdapter.evaluate(StatementAdapter.java:36) >> at >> org.apache.lucene.util.TestRuleAssertionsRequired$1.evaluate(TestRuleAssertionsRequired.java:51) >> at >> org.apache.lucene.util.TestRuleMarkFailure$1.evaluate(TestRuleMarkFailure.java:44) >> at >> org.apache.lucene.util.TestRuleIgnoreAfterMaxFailures$1.evaluate(TestRuleIgnoreAfterMaxFailures.java:60) >> at >> org.apache.lucene.util.TestRuleIgnoreTestSuites$1.evaluate(TestRuleIgnoreTestSuites.java:47) >> at org.junit.rules.RunRules.evaluate(RunRules.java:20) >> at >> com.carrotsearch.randomizedtesting.rules.StatementAdapter.evaluate(StatementAdapter.java:36) >> at >> com.carrotsearch.randomizedtesting.ThreadLeakControl$StatementRunner.run(ThreadLeakControl.java:370) >> at >> com.carrotsearch.randomizedtesting.ThreadLeakControl.lambda$forkTimeoutingTask$0(ThreadLeakControl.java:826) >> at java.base/java.lang.Thread.run(Thread.java:831) >> >> >> FAILED: >> org.apache.solr.handler.component.DistributedFacetPivotLargeTest.test >> >> Error Message: >> java.lang.AssertionError: .responseHeader.status:200!=0 <== >> q=*:*&fq=-real_b:true&rows=0&facet=true&facet.pivot=real_b&facet.missing=true&facet.pivot.mincount=111&facet.sort=index >> >> Stack Trace: >> java.lang.AssertionError: .responseHeader.status:200!=0 <== >> q=*:*&fq=-real_b:true&rows=0&facet=true&facet.pivot=real_b&facet.missing=true&facet.pivot.mincount=111&facet.sort=index >> at >> __randomizedtesting.SeedInfo.seed([FCADEFDBF14367CB:74F9D0015FBF0A33]:0) >> at >> org.apache.solr.handler.component.DistributedFacetPivotLargeTest.test(DistributedFacetPivotLargeTest.java:233) >> at >> java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native >> Method) >> at >> java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:78) >> at >> java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) >> at java.base/java.lang.reflect.Method.invoke(Method.java:567) >> at >> com.carrotsearch.randomizedtesting.RandomizedRunner.invoke(RandomizedRunner.java:1754) >> at >> com.carrotsearch.randomizedtesting.RandomizedRunner$8.evaluate(RandomizedRunner.java:942) >> at >> com.carrotsearch.randomizedtesting.RandomizedRunner$9.evaluate(RandomizedRunner.java:978) >> at >> com.carrotsearch.randomizedtesting.RandomizedRunner$10.evaluate(RandomizedRunner.java:992) >> at >> org.apache.solr.BaseDistributedSearchTestCase$ShardsRepeatRule$ShardsFixedStatement.callStatement(BaseDistributedSearchTestCase.java:1090) >> at >> org.apache.solr.BaseDistributedSearchTestCase$ShardsRepeatRule$ShardsStatement.evaluate(BaseDistributedSearchTestCase.java:1061) >> at >> com.carrotsearch.randomizedtesting.rules.SystemPropertiesRestoreRule$1.evaluate(SystemPropertiesRestoreRule.java:57) >> at org.junit.rules.RunRules.evaluate(RunRules.java:20) >> at >> org.apache.lucene.util.TestRuleSetupTeardownChained$1.evaluate(TestRuleSetupTeardownChained.java:44) >> at >> org.apache.lucene.util.AbstractBeforeAfterRule$1.evaluate(AbstractBeforeAfterRule.java:43) >> at >> org.apache.lucene.util.TestRuleThreadAndTestName$1.evaluate(TestRuleThreadAndTestName.java:45) >> at >> org.apache.lucene.util.TestRuleIgnoreAfterMaxFailures$1.evaluate(TestRuleIgnoreAfterMaxFailures.java:60) >> at >> org.apache.lucene.util.TestRuleMarkFailure$1.evaluate(TestRuleMarkFailure.java:44) >> at org.junit.rules.RunRules.evaluate(RunRules.java:20) >> at >> com.carrotsearch.randomizedtesting.rules.StatementAdapter.evaluate(StatementAdapter.java:36) >> at >> com.carrotsearch.randomizedtesting.ThreadLeakControl$StatementRunner.run(ThreadLeakControl.java:370) >> at >> com.carrotsearch.randomizedtesting.ThreadLeakControl.forkTimeoutingTask(ThreadLeakControl.java:819) >> at >> com.carrotsearch.randomizedtesting.ThreadLeakControl$3.evaluate(ThreadLeakControl.java:470) >> at >> com.carrotsearch.randomizedtesting.RandomizedRunner.runSingleTest(RandomizedRunner.java:951) >> at >> com.carrotsearch.randomizedtesting.RandomizedRunner$5.evaluate(RandomizedRunner.java:836) >> at >> com.carrotsearch.randomizedtesting.RandomizedRunner$6.evaluate(RandomizedRunner.java:887) >> at >> com.carrotsearch.randomizedtesting.RandomizedRunner$7.evaluate(RandomizedRunner.java:898) >> at >> com.carrotsearch.randomizedtesting.rules.StatementAdapter.evaluate(StatementAdapter.java:36) >> at >> com.carrotsearch.randomizedtesting.rules.SystemPropertiesRestoreRule$1.evaluate(SystemPropertiesRestoreRule.java:57) >> at org.junit.rules.RunRules.evaluate(RunRules.java:20) >> at >> org.apache.lucene.util.AbstractBeforeAfterRule$1.evaluate(AbstractBeforeAfterRule.java:43) >> at >> com.carrotsearch.randomizedtesting.rules.StatementAdapter.evaluate(StatementAdapter.java:36) >> at >> org.apache.lucene.util.TestRuleStoreClassName$1.evaluate(TestRuleStoreClassName.java:38) >> at >> com.carrotsearch.randomizedtesting.rules.NoShadowingOrOverridesOnMethodsRule$1.evaluate(NoShadowingOrOverridesOnMethodsRule.java:40) >> at >> com.carrotsearch.randomizedtesting.rules.NoShadowingOrOverridesOnMethodsRule$1.evaluate(NoShadowingOrOverridesOnMethodsRule.java:40) >> at >> com.carrotsearch.randomizedtesting.rules.StatementAdapter.evaluate(StatementAdapter.java:36) >> at >> com.carrotsearch.randomizedtesting.rules.StatementAdapter.evaluate(StatementAdapter.java:36) >> at >> org.apache.lucene.util.TestRuleAssertionsRequired$1.evaluate(TestRuleAssertionsRequired.java:51) >> at >> org.apache.lucene.util.TestRuleMarkFailure$1.evaluate(TestRuleMarkFailure.java:44) >> at >> org.apache.lucene.util.TestRuleIgnoreAfterMaxFailures$1.evaluate(TestRuleIgnoreAfterMaxFailures.java:60) >> at >> org.apache.lucene.util.TestRuleIgnoreTestSuites$1.evaluate(TestRuleIgnoreTestSuites.java:47) >> at org.junit.rules.RunRules.evaluate(RunRules.java:20) >> at >> com.carrotsearch.randomizedtesting.rules.StatementAdapter.evaluate(StatementAdapter.java:36) >> at >> com.carrotsearch.randomizedtesting.ThreadLeakControl$StatementRunner.run(ThreadLeakControl.java:370) >> at >> com.carrotsearch.randomizedtesting.ThreadLeakControl.lambda$forkTimeoutingTask$0(ThreadLeakControl.java:826) >> at java.base/java.lang.Thread.run(Thread.java:831) >> Caused by: junit.framework.AssertionFailedError: >> .responseHeader.status:200!=0 >> at junit.framework.Assert.fail(Assert.java:57) >> at >> org.apache.solr.BaseDistributedSearchTestCase.compareSolrResponses(BaseDistributedSearchTestCase.java:1006) >> at >> org.apache.solr.BaseDistributedSearchTestCase.compareResponses(BaseDistributedSearchTestCase.java:1033) >> at >> org.apache.solr.BaseDistributedSearchTestCase.query(BaseDistributedSearchTestCase.java:679) >> at >> org.apache.solr.BaseDistributedSearchTestCase.query(BaseDistributedSearchTestCase.java:642) >> at >> org.apache.solr.handler.component.DistributedFacetPivotLargeTest.test(DistributedFacetPivotLargeTest.java:226) >> ... 45 more >> >> --------------------------------------------------------------------- >> To unsubscribe, e-mail: [email protected] >> For additional commands, e-mail: [email protected] >> >>
