Sorry, couldn’t figure out how to do that for Solr. I do PRs all day on our 
company system, but that uses Bitbucket.

The “how to contribute” docs just said to make a PR, which didn’t really help. 
I tried, but nothing worked.

wunder
Walter Underwood
[email protected]
http://observer.wunderwood.org/  (my blog)

> On Feb 14, 2021, at 9:56 AM, Atri Sharma <[email protected]> wrote:
> 
> Also, if you could open a PR, it would be easier to review.
> 
> On Sun, 14 Feb 2021, 23:22 Atri Sharma, <[email protected] 
> <mailto:[email protected]>> wrote:
> Apologies for the delay. I will review this tomorrow
> 
> On Sun, 14 Feb 2021, 23:06 Walter Underwood, <[email protected] 
> <mailto:[email protected]>> wrote:
> Please review for 8.9. We will use this feature after it is updated. The 
> current circuit breakers won’t work for us.
> 
> https://issues.apache.org/jira/browse/SOLR-15056 
> <https://issues.apache.org/jira/browse/SOLR-15056>
> 
> This change:
> 
> * Preserves existing functionality.
> * Renames the existing load average circuit breaker to a more accurate name.
> * Adds a circuit breaker for CPU usage that is available if the JVM supports 
> it.
> * Adds detail to documentation, listing which JMX calls each circuit breaker 
> is based on.
> * Copy-edits on docs for more detail, less complicated wording (good when 
> English is not the reader’s primary language)
> * Includes unit tests.
> 
> wunder
> Walter Underwood
> [email protected] <mailto:[email protected]>
> http://observer.wunderwood.org/ <http://observer.wunderwood.org/>  (my blog)
> 

Reply via email to