ok, I will do that then under LUCENE-3447.

Shai

On Sat, Sep 24, 2011 at 10:10 PM, Steven A Rowe <sar...@syr.edu> wrote:

> Hi Shai,****
>
> ** **
>
> Sure, that sounds fine to me.****
>
> ** **
>
> Steve****
>
> ** **
>
> *From:* Shai Erera [mailto:ser...@gmail.com]
> *Sent:* Saturday, September 24, 2011 3:12 AM
>
> *To:* dev@lucene.apache.org
> *Subject:* Re: Prettify JS and CSS exceluded from Javadocs****
>
> ** **
>
> Hi Steve,
>
> As I noted before, jarring prettify won't solve the problem entirely, as
> the references in the HTML will point to an incorrect location.
>
> Why don't we just package prettify.js in the jar like we do with
> stylesheet+prettify.css? We only need this .js as we only write in Java ...
>
> It's a tiny file, and it will simplify the whole process. Wha do you think?
>
> Shai****
>
> On Thu, Sep 22, 2011 at 5:05 PM, Steven A Rowe <sar...@syr.edu> wrote:****
>
> The patch I gave for lucene/contrib-build.xml's "javadocs" target was wrong
> (I placed the <nested> tag outside of the jarify invocation).  Here's a
> fixed patch:****
>
>
> Index: lucene/contrib/contrib-build.xml
> ===================================================================
> --- lucene/contrib/contrib-build.xml    (revision 1165174)
> +++ lucene/contrib/contrib-build.xml    (revision )****
>
> @@ -95,7 +95,11 @@****
>
>            <packageset dir="${src.dir}"/>
>         </sources>****
>
>       </invoke-javadoc>
> -      <jarify basedir="${javadoc.dir}/contrib-${name}"
> destfile="${build.dir}/${final.name}-javadoc.jar"/>****
>
> +      <jarify basedir="${javadoc.dir}/contrib-${name}"
> destfile="${build.dir}/${final.name}-javadoc.jar">****
>
> +        <nested>
> +          <fileset dir="${prettify.dir}"/>
> +        </nested>****
>
> +       </jarify>
>     </sequential>
>   </target>****
>
> ** **
>

Reply via email to