[ https://issues.apache.org/jira/browse/LUCENE-3456?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13114214#comment-13114214 ]
Uwe Schindler commented on LUCENE-3456: --------------------------------------- Yes it's down low, my idea was to do it top-level. But you are right, it's not really needed. And we cannot 100% handle end/close unless we reuse. The problem my approach would solve is that Solr would be asserted all the time, not only if it uses Mock*, which is rarely does? > Analysis Consumers should end and close any TokenStreams > -------------------------------------------------------- > > Key: LUCENE-3456 > URL: https://issues.apache.org/jira/browse/LUCENE-3456 > Project: Lucene - Java > Issue Type: Sub-task > Reporter: Chris Male > > While converting consumers over to using reusableTokenStream, I notice many > don't call end() or close() on TokenStreams. > Even if they are test TSs only created once, we should follow the defined > usage pattern. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org