My statement was inaccurate, I saw the problem when running the smoke tester via the release wizard but the problem was in the release wizard, not the smoke tester.
Thanks Dawid for confirming the intention, I just pushed a fix. Le sam. 20 nov. 2021 à 07:59, Dawid Weiss <[email protected]> a écrit : > Hi Adrien, > > This is an intentional change - I made it. It seemed clearer to me > with the dash. Did you use the smoke tester from the main branch? I > corrected the pattern there as well: > > > https://github.com/apache/lucene/blob/main/dev-tools/scripts/smokeTestRelease.py#L939-L943 > > Dawid > > On Fri, Nov 19, 2021 at 10:48 PM Adrien Grand <[email protected]> wrote: > > > > Hello, > > > > I'm running the release scripts, and there is some inconsistency > > between the build logic that creates a release candidate where the > > name is > > lucene-{version}-RC1-rev-{git hash} > > > > while the smoketester assumes a name that is > > lucene-{version}-RC1-rev{git hash} > > > > (Note that there is no longer a dash between "rev" and the git hash in > > this second name.) > > > > It's pretty easy to fix, but it's not obvious to me if we > > intentionally introduced this additional dash into the RC name, or if > > it was a mistake. For reference, in 8.x there used not to be such a > > dash. > > > > -- > > Adrien > > > > --------------------------------------------------------------------- > > To unsubscribe, e-mail: [email protected] > > For additional commands, e-mail: [email protected] > > > > --------------------------------------------------------------------- > To unsubscribe, e-mail: [email protected] > For additional commands, e-mail: [email protected] > >
