Hi Chris,

 

yes they are not declared “stable” for 9.0 as those are just “automatic module 
names” assigned through manifest based on the gradle module name only. But I 
would say they are still more “stable” than anything we had in 8.x where the 
module system guesses just something from JAR file name. 

 

With the statement I wanted to say: We try to keep the names as noted in my 
previous mail when we will switch to full-featured module system with 
module-info.java, all SPIs declared, exports of packages,… 
(https://issues.apache.org/jira/browse/LUCENE-10255). But there may be the 
requirement to refactor and rename a module.

 

As you were also involved with the JMS @ Oracle before you started at 
Elasticsearch, you may also give some comments about the naming issue. To my 
understanding the new and almost stable module names are safe to be released as 
auto-modules in Lucene 9.0.

 

Uwe

 

P.S.: Not sure with which version you are testing Elasticsearch. The 
automodules were added 2 weeks ago and yesterday we renamed them to have 
fully-qualified domain names. We will merge the PR later and backport to 9.0 
and 9.x branch.

 

-----

Uwe Schindler

Achterdiek 19, D-28357 Bremen

 <https://www.thetaphi.de> https://www.thetaphi.de

eMail: [email protected]

 

From: Dawid Weiss <[email protected]> 
Sent: Tuesday, November 30, 2021 1:19 PM
To: Lucene Dev <[email protected]>
Subject: Re: HEADS UP: Java 9 Module System (JMS) module names for Lucene 
artifacts

 

Getting this fixed in 9.0.0 will allow us to leverage these stable module names 
in requires
directives (without needing to change them anything soon).

 

For the record - they are not considered stable in 9.0.0 -- see Uwe's note 
below (although this was my original 

intention for introducing automatic module names, even if the actual compact 
naming has been so 

fiercely criticized...).

 

LUCENE-10234: Added Automatic-Module-Name to all JARs. This is a first step to 
enable full Java
module system (JMS) support in later Lucene versions. At the moment, the 
automatic names should
not be considered stable. (Dawid Weiss, Uwe Schindler)

 

D. 

Reply via email to