Okay sorry I was confused about these override methods - they are different because of the different access patterns in the sparse/dense cases. Maybe the loss of history was unavoidable since we moved/renamed the file, but I wish we could maintain it.
On Fri, May 13, 2022 at 1:45 PM GitBox <g...@apache.org> wrote: > > > msokolov commented on PR #870: > URL: https://github.com/apache/lucene/pull/870#issuecomment-1126294216 > > Things have been moving kind of fast here! Which is great, but I am trying > to catch up and having trouble reconstructing the changes. Today on main > lucene92/OffHeapVectorValues.java has only one commit in its git history, > and I'm trying to find the place where we added the overrides of > vectorValue() and binaryValue() for the Sparse/Dense subclasses (since they > are copies, it seems weird). I think this has something to do with working > around JVM weirdness - I have a vague memory of a discussion about that, > but I can't find any record of it in git. I tried looking at the old (90 / > 91) readers but I think these changes came after that. I wonder if we lost > the history while doing some git surgery on this feature branch? > > On Tue, May 10, 2022 at 3:17 PM Lu Xugang ***@***.***> wrote: > > > Thanks @mayya-sharipova <https://github.com/mayya-sharipova> , let's move > > to #877 <https://github.com/apache/lucene/pull/877> to continue this > > change. > > > > — > > Reply to this email directly, view it on GitHub > > <https://github.com/apache/lucene/pull/870#issuecomment-1122770417>, or > > unsubscribe > > > <https://github.com/notifications/unsubscribe-auth/AAHHUQP7IQ2XWDGO4TVP773VJKY25ANCNFSM5VG5OC7A> > > . > > You are receiving this because you were mentioned.Message ID: > > ***@***.***> > > > > > > -- > This is an automated message from the Apache Git Service. > To respond to the message, please log on to GitHub and use the > URL above to go to the specific comment. > > To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org > > For queries about this service, please contact Infrastructure at: > us...@infra.apache.org > > > --------------------------------------------------------------------- > To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org > For additional commands, e-mail: issues-h...@lucene.apache.org > --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
