Hi Dawid,
I drafted a PR: https://github.com/apache/lucene/pull/890 Works fine for me locally (I set some Jenkins env vars) or set CI=true. This would require no changes in any build script and we can reuse it for other checks to be enabled by default only in CI environments. Uwe ----- Uwe Schindler Achterdiek 19, D-28357 Bremen https://www.thetaphi.de eMail: [email protected] From: Uwe Schindler <[email protected]> Sent: Friday, May 13, 2022 10:20 PM To: Dawid Weiss <[email protected]>; [email protected] Subject: Re: [JENKINS] Lucene » Lucene-NightlyTests-9.x - Build # 192 - Failure! We should still add a project property and use it instead of tests.nightly. this allows also users to enable errorprone. We can initialize the default based on env back. The Jenkins ones you can see here: https://jenkins.thetaphi.de/job/Lucene-main-Linux/34560/injectedEnvVars/ Uwe Am 13. Mai 2022 20:08:44 UTC schrieb Dawid Weiss <[email protected] <mailto:[email protected]> >: >> >> >> Not sure why it was configured like that. The sysproo makes no sense to me >> (why only on nightly tests?). >> > >Because errorprone is sloooow. > >I would say: Let's add a separate project property like "cibuild=true". I >> can put that into Gradle property file on all nenks, too. So errorprone >> runs on all ci builds. >> > >Typically all CI servers will have some ("CI") environment variable set to >true. > >D. > >> -- Uwe Schindler Achterdiek 19, 28357 Bremen https://www.thetaphi.de -- Uwe Schindler Achterdiek 19, 28357 Bremen https://www.thetaphi.de
