Thanks Julie, I looked and left some minor comments. Let's target that searchNearestVectors refactor for 9.4.0.
As for removing the generics, it would be great if we can further simplify, but agree it doesn't seem critical to target this release, although if we can get it pushed by next week that would be fine too; it doesn't sound risky? But there is also a potential to touch a lot of code, so let's not rush it either :) We also need to wrap up https://github.com/apache/lucene/pull/11743. I believe that looks ready to push and we have decided to maintain the current indexing strategy. Mayya - are you ready to push, or do you anticipate any further work there? On Wed, Sep 7, 2022 at 12:32 PM Julie Tibshirani <juliet...@gmail.com> wrote: > > Hi Mike, I've been working on follow-up refactors to the vector encoding work > we just added in 9.4 (https://github.com/apache/lucene/pull/1054) and had a > couple things to check with you. > > First, I opened a PR to remove LeafReader#searchNearestVectorsExhaustively > (https://github.com/apache/lucene/pull/11756). If you're happy with the > change, I'd like to backport it to 9.4 to minimize changes to the LeafReader > API. This seemed okay to me, since it's just a refactor and has no new > functionality. > > I'm also looking into simplifying KnnVectorsWriter to remove the generics we > added. I may not complete this in time for 9.4. But I'm not too worried about > pushing this out, since this is a codec-level API, and changing it won't be > very disruptive to users. > > Julie > > On Fri, Sep 2, 2022 at 10:57 PM Tomoko Uchida <tomoko.uchida.1...@gmail.com> > wrote: >> >> > Branch branch_9_4 has been cut and versions updated to 9.5 on stable >> > branch. >> >> Then the GitHub Milestone for 9.5 also needs to be created. >> >> This time, I created Milestone 9.5.0. We should include it in the release >> process. >> https://github.com/apache/lucene/milestone/4 >> >> >> 2022年9月3日(土) 4:42 Michael Sokolov <msoko...@gmail.com>: >>> >>> NOTICE: >>> >>> Branch branch_9_4 has been cut and versions updated to 9.5 on stable branch. >>> >>> Please observe the normal rules: >>> >>> * No new features may be committed to the branch. >>> * Documentation patches, build patches and serious bug fixes may be >>> committed to the branch. However, you should submit all patches you >>> want to commit to Jira first to give others the chance to review >>> and possibly vote against the patch. Keep in mind that it is our >>> main intention to keep the branch as stable as possible. >>> * All patches that are intended for the branch should first be committed >>> to the unstable branch, merged into the stable branch, and then into >>> the current release branch. >>> * Normal unstable and stable branch development may continue as usual. >>> However, if you plan to commit a big change to the unstable branch >>> while the branch feature freeze is in effect, think twice: can't the >>> addition wait a couple more days? Merges of bug fixes into the branch >>> may become more difficult. >>> * Only Jira issues with Fix version 9.4 and priority "Blocker" will delay >>> a release candidate build. >>> >>> --------------------------------------------------------------------- >>> To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org >>> For additional commands, e-mail: dev-h...@lucene.apache.org >>> --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
