I change my vote to +1 based on Julie's test. It fails for me with 9.4.0 and passes for me with 9.4.1
:lucene:core:test (SUCCESS): 1 test(s) > Task :lucene:core:wipeTaskTemp The slowest tests (exceeding 500 ms) during this run: 8511.54s TestManyKnnVectors.testLargeSegment (:lucene:core) The slowest suites (exceeding 1s) during this run: 8512.27s TestManyKnnVectors (:lucene:core) BUILD SUCCESSFUL in 2h 22m 55s 19 actionable tasks: 13 executed, 6 up-to-date On Thu, Oct 20, 2022 at 3:57 PM Robert Muir <rcm...@gmail.com> wrote: > > Thank you Julie for the draft test! I will try to reproduce/test with it. > > On Thu, Oct 20, 2022 at 3:45 PM Julie Tibshirani <juliet...@gmail.com> wrote: > > > > Thank you Ignacio for taking over as release manager! I ran into some > > issues with my signing key and Ignacio saved the day. > > > > Robert, I understand your perspective. I uploaded a draft PR with a monster > > test you could try out: https://github.com/apache/lucene/pull/11867. It > > requires downloading an external dataset based on some StackOverflow data > > where I found the bug. Let me know if you run into problems with the test > > -- maybe we can discuss on the draft PR. > > > > Julie > > > > On Thu, Oct 20, 2022 at 10:17 AM Uwe Schindler <u...@thetaphi.de> wrote: > >> > >> Hi, > >> > >> Policeman Jenkins ran the smoke checks for me with Java 11 and Java 17, > >> still no Java 19 :( > >> > >> SUCCESS! [1:26:17.692239] > >> Finished: SUCCESS > >> > >> I did not do any special checks beyond smoke tester. To me the Bugfix > >> looks fine. > >> > >> +1 to release! > >> > >> Uwe > >> > >> Am 20. Oktober 2022 16:24:23 MESZ schrieb Ignacio Vera <iver...@gmail.com>: > >>> > >>> Please vote for release candidate 1 for Lucene 9.4.1 > >>> > >>> > >>> The artifacts can be downloaded from: > >>> > >>> https://dist.apache.org/repos/dist/dev/lucene/lucene-9.4.1-RC1-rev-810817993e0956e63e29906e78a245949501b77d > >>> > >>> > >>> You can run the smoke tester directly with this command: > >>> > >>> > >>> python3 -u dev-tools/scripts/smokeTestRelease.py \ > >>> > >>> https://dist.apache.org/repos/dist/dev/lucene/lucene-9.4.1-RC1-rev-810817993e0956e63e29906e78a245949501b77d > >>> > >>> > >>> The vote will be open for at least 72 hours i.e. until 2022-10-23 15:00 > >>> UTC. > >>> > >>> > >>> [ ] +1 approve > >>> > >>> [ ] +0 no opinion > >>> > >>> [ ] -1 disapprove (and reason why) > >>> > >>> > >>> Here is my +1 > >>> > >>> ---- > >> > >> -- > >> Uwe Schindler > >> Achterdiek 19, 28357 Bremen > >> https://www.thetaphi.de --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
