[ 
https://issues.apache.org/jira/browse/LUCENE-3186?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Simon Willnauer updated LUCENE-3186:
------------------------------------

    Attachment: LUCENE-3186.patch

here is an initial patch that promotes the following types:
 * all permutations of int8, int16, int32, int64 and packed ints
 * all permutations of float32 and float 64
 * all permutations of var_deref_bytes, var_straight_bytes, fixed_deref_bytes, 
fixed_straight_bytes
 * all permuations of sorted_fixed_bytes and sorted_var_bytes

general rule here is that var wins over fixed and straight wins over deref. For 
int types variable ints wins over all other fixed types (according to var wins 
over fixed). 

if those types are mixed up like float32 and int32 this patch drops the 
docvalues field. 

this patch is still very rough and has one rather critical nocommit in 
SegmentMerger since I am changeing the FieldInfo for a field if I promote the 
type or drop the dv field which essentially means that I need to write the FI 
after this has been done.
                
> DocValues type should be recored in FNX file to early fail if user specifies 
> incompatible type
> ----------------------------------------------------------------------------------------------
>
>                 Key: LUCENE-3186
>                 URL: https://issues.apache.org/jira/browse/LUCENE-3186
>             Project: Lucene - Java
>          Issue Type: Improvement
>          Components: core/index
>    Affects Versions: 4.0
>            Reporter: Simon Willnauer
>            Assignee: Simon Willnauer
>             Fix For: 4.0
>
>         Attachments: LUCENE-3186.patch
>
>
> Currently segment merger fails if the docvalues type is not compatible across 
> segments. We already catch this problem if somebody changes the values type 
> for a field within one segment but not across segments. in order to do that 
> we should record the type in the fnx fiel alone with the field numbers.
> I marked this 4.0 since it should not block the landing on trunk

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to