Hi all, quick update: https://github.com/apache/lucene/pull/13850 should fix the hanging issue, PR is already merged and backported to branch_10_0.
My understanding is that before respinning, we want to add additional tests to reproduce the issue and ensure it is fixed. Does that align with your expectations? Anything to add? On the discountOverlaps issue (https://github.com/apache/lucene/pull/13845 ): I have no context to determine how severe that bug is, yet it seems like the fix is low risk. I would not delay respinning because of it but I'd be in favour of backporting the change if it gets reviewed and merged between now and when we are ready to respin. Could we also add the missing CHANGES entry for the original change (https://github.com/apache/lucene/pull/13757) and the migrate guide entry if needed, please? Any other opinions? On Wed, Oct 2, 2024 at 3:48 PM Christine Poerschke (BLOOMBERG/ LONDON) < cpoersc...@bloomberg.net> wrote: > Hi Everyone, > > If there was to be a respin then I'd like to nominate > https://github.com/apache/lucene/pull/13845 to be considered to be in it, > it's for the addition of missing similarity constructor variants. > > Thanks, > Christine > > From: dev@lucene.apache.org At: 10/02/24 10:06:56 UTC+1:00 > To: dev@lucene.apache.org > Subject: Re: [VOTE] Release Lucene 10.0.0 RC1 > > Hi Mike, > Thanks for raising your concern. > > Do you have any more insight into the cause of the nightly test hang? I'd > like to understand if it may be caused by recent changes on main, env > issues, or a pre-existing issue that may be part of already released code. > > I've been looking at jenkins (https://ci-builds.apache.org/job/Lucene/) > to check on the new jobs for 10x and 10.0 that I added yesterday and it > seems that they were never built. I wonder if that's related to this issue. > > Also, happy to help with the investigation, I know that Chris is also > spending some time trying to reproduce it. > > Thanks > Luca > > On Tue, Oct 1, 2024 at 10:31 PM Michael McCandless < > luc...@mikemccandless.com> wrote: > >> Hi Team, >> >> I'm worried about https://github.com/apache/lucene/issues/13844 -- a >> hang during HNSW indexing, uncovered in nightly benchy. I'm seeing if the >> hang reproduces ... but it might be a blocker for 10.0.0 release if it's >> real / repros? Then again, it must be quite rare ... >> >> Mike McCandless >> >> http://blog.mikemccandless.com >> >> >> On Tue, Oct 1, 2024 at 12:36 PM Chris Hegarty >> <christopher.hega...@elastic.co.invalid> wrote: >> >>> >>> SUCCESS! [0:53:16.589622] >>> >>> +1 (binding) >>> >>> -Chris. >>> >>> > On 1 Oct 2024, at 16:32, Luca Cavanna <java...@apache.org> wrote: >>> > >>> > Please vote for release candidate 1 for Lucene 10.0.0 >>> > >>> > I published a draft of the release notes at >>> https://cwiki.apache.org/confluence/display/LUCENE/Release+Notes+10.0.0 >>> . Feedback is welcome. Feel free to edit directly. >>> > >>> > The artifacts can be downloaded from: >>> > >>> https://dist.apache.org/repos/dist/dev/lucene/lucene-10.0.0-RC1-rev-4461bc1eff44c26c149b6ff96a667ce68c6866a4 >>> > >>> > You can run the smoke tester directly with this command: >>> > >>> > python3 -u dev-tools/scripts/smokeTestRelease.py \ >>> > >>> https://dist.apache.org/repos/dist/dev/lucene/lucene-10.0.0-RC1-rev-4461bc1eff44c26c149b6ff96a667ce68c6866a4 >>> > >>> > The vote will be open for at least 72 hours i.e. until 2024-10-04 >>> 15:00 UTC. >>> > >>> > [ ] +1 approve >>> > [ ] +0 no opinion >>> > [ ] -1 disapprove (and reason why) >>> > >>> > Here is my +1: >>> > >>> > SUCCESS! [0:45:06.247409] >>> > >>> > >>> > Cheers >>> > Luca >>> >>> >>> --------------------------------------------------------------------- >>> To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org >>> For additional commands, e-mail: dev-h...@lucene.apache.org >>> >>> >
