This vote is cancelled. We will do a respin with changes to make JDK 25 the default vectorization provider.
Uwe – do we want to chase down the test failure you've seen as a blocker, before we do RC2? Are we able to repro it with a test seed? On Fri, Sep 5, 2025 at 2:54 PM Michael Sokolov <[email protected]> wrote: > oh I guess we need to actually create the thing, sorry I pulled the > latest changes and ran the smoketester, but I think that actually just > tested RC1, duh. I'll rescind my +1, and -1 for RC1 > > On Fri, Sep 5, 2025 at 5:53 PM Michael Sokolov <[email protected]> wrote: > > > > SUCCESS! [1:08:55.634042] > > > > > > Do we need a new vote thread for RC 2? I'm not sure, but I think we > > do. Anyway I am +1 to release it. > > > > On Fri, Sep 5, 2025 at 11:25 AM Uwe Schindler <[email protected]> wrote: > > > > > > Hi, I also started it. > > > > > > But before we respin, I got this error while running tests (this was > against Java 22, Java 21 passed). I have seen the same issue from time to > time in normal Jenkins tests. The file count limitation is caused by > MockFS, so its a real bug because the tests seems to really open too many > files. Maybe it is because of some strange random defaults.: > > > > > > > Task :lucene:core:test > > > > > > TestIndexWriterWithThreads > testCloseWithThreads FAILED > > > java.nio.file.FileSystemException: > /home/jenkins/workspace/Lucene-10.x-Release-Tester/smoketmp/unpack/lucene-10.3.0/lucene/core/build/tmp/tests-tmp/lucene.index.TestIndexWriterWithThreads_33B64C18757A2078-001/index-NIOFSDirectory-002/_1.tvx: > Too many open files > > > at > __randomizedtesting.SeedInfo.seed([33B64C18757A2078:2E72656F168F3ADE]:0) > > > at > org.apache.lucene.tests.mockfile.HandleLimitFS.onOpen(HandleLimitFS.java:67) > > > at > org.apache.lucene.tests.mockfile.HandleTrackingFS.callOpenHook(HandleTrackingFS.java:82) > > > at > org.apache.lucene.tests.mockfile.HandleTrackingFS.newFileChannel(HandleTrackingFS.java:202) > > > at > org.apache.lucene.tests.mockfile.HandleTrackingFS.newFileChannel(HandleTrackingFS.java:171) > > > at > org.apache.lucene.tests.mockfile.FilterFileSystemProvider.newFileChannel(FilterFileSystemProvider.java:206) > > > at > java.base/java.nio.channels.FileChannel.open(FileChannel.java:309) > > > at > java.base/java.nio.channels.FileChannel.open(FileChannel.java:369) > > > at > org.apache.lucene.store.NIOFSDirectory.openInput(NIOFSDirectory.java:78) > > > at > org.apache.lucene.tests.util.LuceneTestCase.slowFileExists(LuceneTestCase.java:3089) > > > at > org.apache.lucene.tests.store.MockDirectoryWrapper.openInput(MockDirectoryWrapper.java:801) > > > at > org.apache.lucene.codecs.lucene90.compressing.FieldsIndexReader.<init>(FieldsIndexReader.java:70) > > > at > org.apache.lucene.codecs.lucene90.compressing.Lucene90CompressingTermVectorsReader.<init>(Lucene90CompressingTermVectorsReader.java:185) > > > at > org.apache.lucene.codecs.lucene90.compressing.Lucene90CompressingTermVectorsFormat.vectorsReader(Lucene90CompressingTermVectorsFormat.java:96) > > > at > org.apache.lucene.tests.codecs.asserting.AssertingTermVectorsFormat.vectorsReader(AssertingTermVectorsFormat.java:45) > > > at > org.apache.lucene.index.SegmentCoreReaders.<init>(SegmentCoreReaders.java:125) > > > at > org.apache.lucene.index.SegmentReader.<init>(SegmentReader.java:95) > > > at > org.apache.lucene.index.ReadersAndUpdates.getReader(ReadersAndUpdates.java:180) > > > at > org.apache.lucene.index.BufferedUpdatesStream$SegmentState.<init>(BufferedUpdatesStream.java:278) > > > at > org.apache.lucene.index.IndexWriter.openSegmentStates(IndexWriter.java:6504) > > > at > org.apache.lucene.index.IndexWriter.forceApply(IndexWriter.java:6278) > > > at > org.apache.lucene.index.IndexWriter.tryApply(IndexWriter.java:6212) > > > at > org.apache.lucene.index.IndexWriter.lambda$publishFrozenUpdates$12(IndexWriter.java:2833) > > > at > org.apache.lucene.index.IndexWriter$EventQueue.processEventsInternal(IndexWriter.java:339) > > > at > org.apache.lucene.index.IndexWriter$EventQueue.processEvents(IndexWriter.java:328) > > > at > org.apache.lucene.index.IndexWriter.processEvents(IndexWriter.java:6055) > > > at > org.apache.lucene.index.IndexWriter.prepareCommitInternal(IndexWriter.java:3718) > > > at > org.apache.lucene.index.IndexWriter.commitInternal(IndexWriter.java:4154) > > > at > org.apache.lucene.index.IndexWriter.commit(IndexWriter.java:4116) > > > at > org.apache.lucene.index.TestIndexWriterWithThreads.testCloseWithThreads(TestIndexWriterWithThreads.java:240) > > > at > java.base/jdk.internal.reflect.DirectMethodHandleAccessor.invoke(DirectMethodHandleAccessor.java:103) > > > at java.base/java.lang.reflect.Method.invoke(Method.java:580) > > > at > com.carrotsearch.randomizedtesting.RandomizedRunner.invoke(RandomizedRunner.java:1758) > > > at > com.carrotsearch.randomizedtesting.RandomizedRunner$8.evaluate(RandomizedRunner.java:946) > > > at > com.carrotsearch.randomizedtesting.RandomizedRunner$9.evaluate(RandomizedRunner.java:982) > > > at > com.carrotsearch.randomizedtesting.RandomizedRunner$10.evaluate(RandomizedRunner.java:996) > > > at > org.apache.lucene.tests.util.TestRuleSetupTeardownChained$1.evaluate(TestRuleSetupTeardownChained.java:48) > > > at > org.apache.lucene.tests.util.AbstractBeforeAfterRule$1.evaluate(AbstractBeforeAfterRule.java:43) > > > at > org.apache.lucene.tests.util.TestRuleThreadAndTestName$1.evaluate(TestRuleThreadAndTestName.java:45) > > > at > org.apache.lucene.tests.util.TestRuleIgnoreAfterMaxFailures$1.evaluate(TestRuleIgnoreAfterMaxFailures.java:60) > > > at > org.apache.lucene.tests.util.TestRuleMarkFailure$1.evaluate(TestRuleMarkFailure.java:44) > > > at org.junit.rules.RunRules.evaluate(RunRules.java:20) > > > at > com.carrotsearch.randomizedtesting.rules.StatementAdapter.evaluate(StatementAdapter.java:36) > > > at > com.carrotsearch.randomizedtesting.ThreadLeakControl$StatementRunner.run(ThreadLeakControl.java:390) > > > at > com.carrotsearch.randomizedtesting.ThreadLeakControl.forkTimeoutingTask(ThreadLeakControl.java:843) > > > at > com.carrotsearch.randomizedtesting.ThreadLeakControl$3.evaluate(ThreadLeakControl.java:490) > > > at > com.carrotsearch.randomizedtesting.RandomizedRunner.runSingleTest(RandomizedRunner.java:955) > > > at > com.carrotsearch.randomizedtesting.RandomizedRunner$5.evaluate(RandomizedRunner.java:840) > > > at > com.carrotsearch.randomizedtesting.RandomizedRunner$6.evaluate(RandomizedRunner.java:891) > > > at > com.carrotsearch.randomizedtesting.RandomizedRunner$7.evaluate(RandomizedRunner.java:902) > > > at > org.apache.lucene.tests.util.AbstractBeforeAfterRule$1.evaluate(AbstractBeforeAfterRule.java:43) > > > at > com.carrotsearch.randomizedtesting.rules.StatementAdapter.evaluate(StatementAdapter.java:36) > > > at > org.apache.lucene.tests.util.TestRuleStoreClassName$1.evaluate(TestRuleStoreClassName.java:38) > > > at > com.carrotsearch.randomizedtesting.rules.NoShadowingOrOverridesOnMethodsRule$1.evaluate(NoShadowingOrOverridesOnMethodsRule.java:40) > > > at > com.carrotsearch.randomizedtesting.rules.NoShadowingOrOverridesOnMethodsRule$1.evaluate(NoShadowingOrOverridesOnMethodsRule.java:40) > > > at > com.carrotsearch.randomizedtesting.rules.StatementAdapter.evaluate(StatementAdapter.java:36) > > > at > com.carrotsearch.randomizedtesting.rules.StatementAdapter.evaluate(StatementAdapter.java:36) > > > at > org.apache.lucene.tests.util.TestRuleAssertionsRequired$1.evaluate(TestRuleAssertionsRequired.java:53) > > > at > org.apache.lucene.tests.util.AbstractBeforeAfterRule$1.evaluate(AbstractBeforeAfterRule.java:43) > > > at > org.apache.lucene.tests.util.TestRuleMarkFailure$1.evaluate(TestRuleMarkFailure.java:44) > > > at > org.apache.lucene.tests.util.TestRuleIgnoreAfterMaxFailures$1.evaluate(TestRuleIgnoreAfterMaxFailures.java:60) > > > at > org.apache.lucene.tests.util.TestRuleIgnoreTestSuites$1.evaluate(TestRuleIgnoreTestSuites.java:47) > > > at org.junit.rules.RunRules.evaluate(RunRules.java:20) > > > at > com.carrotsearch.randomizedtesting.rules.StatementAdapter.evaluate(StatementAdapter.java:36) > > > at > com.carrotsearch.randomizedtesting.ThreadLeakControl$StatementRunner.run(ThreadLeakControl.java:390) > > > at > com.carrotsearch.randomizedtesting.ThreadLeakControl.lambda$forkTimeoutingTask$0(ThreadLeakControl.java:850) > > > at java.base/java.lang.Thread.run(Thread.java:1570) > > > > > > > > > -1 to release, let's get the Chris Hegarthy changes about Java 25 > vectorization in. > > > > > > Uwe > > > > > > > > > Am 05.09.2025 um 14:17 schrieb Luca Cavanna: > > > > > > I started this in my lunch break, posting results although it seems we > will need a new RC: > > > > > > +1 SUCCESS! [0:54:58.917675] > > > > > > On Fri, Sep 5, 2025 at 1:56 PM Chris Hegarty > <[email protected]> wrote: > > >> > > >> Hi, > > >> > > >> I’m sorry that I missed this earlier, but with the upcoming release > of JDK 25 we should bump the upper bound JDK version check in our > vectorization provider. > > >> > > >> The changes are trivial, but do we want to do a new RC for this, > since JDK 25 is due Sep 16th. > > >> > > >> https://github.com/apache/lucene/pull/15157 - work in progress, but > I’ll get it into the various branches soon. > > >> > > >> -Chris > > >> > > >> > On 5 Sep 2025, at 10:59, Adrien Grand <[email protected]> wrote: > > >> > > > >> > +1 SUCCESS! [0:47:41.351723] > > >> > > > >> > On Fri, Sep 5, 2025 at 10:24 AM Ignacio Vera <[email protected]> > wrote: > > >> > +1 (binding) > > >> > SUCCESS! [1:13:08.487251] > > >> > > > >> > On Fri, Sep 5, 2025 at 1:25 AM Ankit Jain <[email protected]> > wrote: > > >> > Okay, I could finally get it to work. Let's go!! > > >> > > > >> > +1 (non binding) > > >> > SUCCESS! [1:13:59.906562] > > >> > > > >> > On Thu, Sep 4, 2025 at 11:06 AM Michael Sokolov <[email protected]> > wrote: > > >> > I managed to get python 3.12 installed (using pyenv) and re-ran, but > > >> > now I'm also seeing problems related to missing keys. I will try > > >> > again tomorrow > > >> > > > >> > On Thu, Sep 4, 2025 at 1:26 PM Vigya Sharma <[email protected]> > wrote: > > >> > > > > >> > > Oh no! My key wasn't in the KEYS file so I had to manually add it > on my machine to do the build. I used the following command: > > >> > > > > >> > > { MYKEY=4FB8850B; echo; gpg --list-public-keys $MYKEY; gpg > --export -a --export-options no-export-attributes,export-minimal $MYKEY; } > >> KEYS > > >> > > > > >> > > Then the release steps succeeded and it uploaded the artifacts. > But I don't think it uploads the KEYS file? Do I need to do something to > separately push the new KEYS file with my key added? > > >> > > > > >> > > Vigya > > >> > > > > >> > > On Thu, Sep 4, 2025 at 9:58 AM Ankit Jain <[email protected]> > wrote: > > >> > >> > > >> > >> Probably, it takes some time for the key to sync. Still running > into the same issue with ("gpg: Can't check signature: No public key") > > >> > >> > > >> > >> On Thu, Sep 4, 2025 at 9:46 AM Adrien Grand <[email protected]> > wrote: > > >> > >>> > > >> > >>> I added Vigya's key to the KEYS file, hopefully this fixes the > problem (once archive.apache.org syncs). > > >> > >>> > > >> > >>> On Thu, Sep 4, 2025 at 6:22 PM Adrien Grand <[email protected]> > wrote: > > >> > >>>> > > >> > >>>> I'm running with Python 3.12.1 and don't get this error. > > >> > >>>> > > >> > >>>> However GPG complains about the signature. ("gpg: Can't check > signature: No public key") I believe that this is due to the fact that > Vigya's key is not in Lucene's KEYS file? ( > https://archive.apache.org/dist/lucene/KEYS) > > >> > >>>> > > >> > >>>> On Thu, Sep 4, 2025 at 4:58 PM Michael Sokolov < > [email protected]> wrote: > > >> > >>>>> > > >> > >>>>> does the smokeTester require fancy new python now? It seems > to fail > > >> > >>>>> for me with python 3.9: > > >> > >>>>> > > >> > >>>>> sokolovm@sok➜~/workspace/lucene(branch_10_3)» python3 -u > > >> > >>>>> dev-tools/scripts/smokeTestRelease.py \ > > >> > >>>>> [14:56:23] > > >> > >>>>> > https://dist.apache.org/repos/dist/dev/lucene/lucene-10.3.0-RC1-rev-878a3db9c2d029020b0fcb2b00de314940cced96 > > >> > >>>>> Traceback (most recent call last): > > >> > >>>>> File > "/local/home/sokolovm/workspace/lucene/dev-tools/scripts/smokeTestRelease.py", > > >> > >>>>> line 40, in <module> > > >> > >>>>> import scriptutil > > >> > >>>>> File > "/local/home/sokolovm/workspace/lucene/dev-tools/scripts/scriptutil.py", > > >> > >>>>> line 26, in <module> > > >> > >>>>> from typing import Self, override > > >> > >>>>> ImportError: cannot import name 'Self' from 'typing' > > >> > >>>>> (/apollo/env/EnvImprovement/python3.9/lib/python3.9/typing.py) > > >> > >>>>> > > >> > >>>>> On Thu, Sep 4, 2025 at 2:58 AM Vigya Sharma < > [email protected]> wrote: > > >> > >>>>> > > > >> > >>>>> > Please vote for release candidate 1 for Lucene 10.3.0 > > >> > >>>>> > > > >> > >>>>> > The artifacts can be downloaded from: > > >> > >>>>> > > https://dist.apache.org/repos/dist/dev/lucene/lucene-10.3.0-RC1-rev-878a3db9c2d029020b0fcb2b00de314940cced96 > > >> > >>>>> > > > >> > >>>>> > You can run the smoke tester directly with this command: > > >> > >>>>> > > > >> > >>>>> > python3 -u dev-tools/scripts/smokeTestRelease.py \ > > >> > >>>>> > > https://dist.apache.org/repos/dist/dev/lucene/lucene-10.3.0-RC1-rev-878a3db9c2d029020b0fcb2b00de314940cced96 > > >> > >>>>> > > > >> > >>>>> > The vote will be open for at least 72 hours i.e. until > 2025-09-08 07:00 UTC. > > >> > >>>>> > > > >> > >>>>> > [ ] +1 approve > > >> > >>>>> > [ ] +0 no opinion > > >> > >>>>> > [ ] -1 disapprove (and reason why) > > >> > >>>>> > > > >> > >>>>> > Here is my +1 > > >> > >>>>> > ---- > > >> > >>>>> > > >> > >>>>> > --------------------------------------------------------------------- > > >> > >>>>> To unsubscribe, e-mail: [email protected] > > >> > >>>>> For additional commands, e-mail: [email protected] > > >> > >>>>> > > >> > >>>> > > >> > >>>> > > >> > >>>> -- > > >> > >>>> Adrien > > >> > >>> > > >> > >>> > > >> > >>> > > >> > >>> -- > > >> > >>> Adrien > > >> > > > >> > > --------------------------------------------------------------------- > > >> > To unsubscribe, e-mail: [email protected] > > >> > For additional commands, e-mail: [email protected] > > >> > > > >> > > > >> > > > >> > -- > > >> > Adrien > > >> > > >> > > >> --------------------------------------------------------------------- > > >> To unsubscribe, e-mail: [email protected] > > >> For additional commands, e-mail: [email protected] > > >> > > > -- > > > Uwe Schindler > > > Achterdiek 19, D-28357 Bremen > > > https://www.thetaphi.de > > > eMail: [email protected] > > --------------------------------------------------------------------- > To unsubscribe, e-mail: [email protected] > For additional commands, e-mail: [email protected] > >
