I think the '.' was originally put there because on openjdk impls of javac, the 'java.version' sysprop (which is the first part of what the lucene build puts in the 'X-Build-JDK' header) has values like "21.0.2"
FWIW: On main the smoketester was updated to use a regex for checking X-Build-JDK, expecting either a '.' or a ' ' character to follow the BASE_JAVA_VERSION. : Date: Wed, 1 Oct 2025 18:43:04 -0400 : From: Robert Muir <[email protected]> : Reply-To: [email protected] : To: [email protected] : Subject: Re: Weird release failure : : Looks like a bug in the smoketester. Removing the "." (period) in the : check should fix it: : : - "X-Build-JDK: %s." % BASE_JAVA_VERSION, : + "X-Build-JDK: %s" % BASE_JAVA_VERSION, : : On Wed, Oct 1, 2025 at 6:03 PM Benjamin Trent <[email protected]> wrote: : > : > Hey y'all, : > : > It's been awhile since I have done a release, while running the smoke tester I got the following failure: : > : > RuntimeError: JAR file "/Users/benjamintrent/.lucene-releases/10.3.1/RC1/smoketest/unpack/lucene-10.3.1/modules-test-framework/lucene-test-framework-10.3.1.jar" is missing "X-Build-JDK: 21." inside its META-INF/MANIFEST.MF: Manifest-Version: 1.0 : > Extension-Name: org.apache.lucene : > Implementation-Vendor: The Apache Software Foundation : > Implementation-Title: org.apache.lucene : > Implementation-Version: 10.3.1 25d6374b4981073547bc96173b1c27922f4ea0f3 : > - 2025-10-01 16:53:01 : > Specification-Vendor: The Apache Software Foundation : > Specification-Version: 10.3.1 : > Specification-Title: Lucene Search Engine: test-framework : > X-Compile-Source-JDK: 21 : > X-Compile-Target-JDK: 21 : > X-Build-JDK: 21 (Oracle Corporation 21+35-2513) : > X-Build-OS: Mac OS X aarch64 15.7 : > : > Which is weird, it SEEMS like the build JDK is indeed 21. Just not the right particular kind of Java 21? : > : > I will keep debugging, but wanted to reach out to see if somebody had a quick answer. : > : > Thanks! : > : > Ben : : --------------------------------------------------------------------- : To unsubscribe, e-mail: [email protected] : For additional commands, e-mail: [email protected] : : -Hoss http://www.lucidworks.com/
--------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
