[
https://issues.apache.org/jira/browse/LUCENE-3485?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13120232#comment-13120232
]
Shai Erera commented on LUCENE-3485:
------------------------------------
Good catch Gilad ! Do you intend to prepare a patch?
Also, we probably shouldn't close the directory in close(), since it was given
to us from the outside. So it's whoever created the directory responsibility to
close it. We should however eliminate the two deprecated ctors which take a
File -- no need to have them around anymore, and we're not bound to back-compat
in this module, yet :).
> LuceneTaxonomyReader .decRef() may close the inner IR, renderring the LTR in
> a limbo.
> -------------------------------------------------------------------------------------
>
> Key: LUCENE-3485
> URL: https://issues.apache.org/jira/browse/LUCENE-3485
> Project: Lucene - Java
> Issue Type: Bug
> Components: modules/facet
> Affects Versions: 3.4
> Reporter: Gilad Barkai
> Priority: Minor
>
> TaxonomyReader which supports ref-counting, has a decRef() method which
> delegates to an inner IndexReader and calls its .decRef(). The latter may
> close the reader (if the ref is zeroes) but the taxonomy would remain 'open'
> which will fail many of its method calls.
> Also, the LTR's .close() method does not work in the same manner as
> IndexReader's - which calls decRef(), and leaves the real closing logic to
> the decRef(). I believe this should be the right approach for the fix.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
