[ https://issues.apache.org/jira/browse/LUCENE-3486?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13120662#comment-13120662 ]
Shai Erera commented on LUCENE-3486: ------------------------------------ Looks good. I noticed you marked close() with @Override. Are we on Java 6 in 3.x? > Add SearcherLifetimeManager, so you can retrieve the same searcher you > previously used > -------------------------------------------------------------------------------------- > > Key: LUCENE-3486 > URL: https://issues.apache.org/jira/browse/LUCENE-3486 > Project: Lucene - Java > Issue Type: New Feature > Components: core/search > Reporter: Michael McCandless > Assignee: Michael McCandless > Fix For: 3.5, 4.0 > > Attachments: LUCENE-3486.patch, LUCENE-3486.patch > > > The idea is similar to SOLR-2809 (adding searcher leases to Solr). > This utility class sits above whatever your source is for "the > current" searcher (eg NRTManager, SearcherManager, etc.), and records > (holds a reference to) each searcher in recent history. > The idea is to ensure that when a user does a follow-on action (clicks > next page, drills down/up), or when two or more searcher invocations > within a single user search need to happen against the same searcher > (eg in distributed search), you can retrieve the same searcher you > used "last time". > I think with the new searchAfter API (LUCENE-2215), doing follow-on > searches on the same searcher is more important, since the "bottom" > (score/docID) held for that API can easily shift when a new searcher > is opened. > When you do a "new" search, you record the searcher you used with the > manager, and it returns to you a long token (currently just the > IR.getVersion()), which you can later use to retrieve the same > searcher. > Separately you must periodically call prune(), to prune the old > searchers, ideally from the same thread / at the same time that > you open a new searcher. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org