[
https://issues.apache.org/jira/browse/LUCENE-3489?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13121098#comment-13121098
]
Dawid Weiss commented on LUCENE-3489:
-------------------------------------
Yeah, I figured that you want to keep it compact. These may be compatible
because there's nothing forbidding us to keep LuceneTestCase as a base class
(descending from Assert and providing Lucene-related infrastructure). I'm just
trying to push all the randomization (seed initialization, reproducibility,
thread controls) out of LuceneTestCase and into something more generic. So far
it looks good to my eyes, but I'll be looking forward to your strict German
opinion, Uwe :)
Oh, by the way -- is there any particular reason for so many things to be
static (class level)? I get these are fixtures reused by tests but would people
scream if they were object-level fixtures rather than class-level fixtures?
It'd make things a bit easier... starting with the need for a single initial
seed, for example.
> Refactor test classes that use assumeFalse(codec != SimpleText, Memory) to
> use new annotation and move the expensive methods to separate classes
> ------------------------------------------------------------------------------------------------------------------------------------------------
>
> Key: LUCENE-3489
> URL: https://issues.apache.org/jira/browse/LUCENE-3489
> Project: Lucene - Java
> Issue Type: Test
> Components: general/test
> Affects Versions: 4.0
> Reporter: Uwe Schindler
> Fix For: 4.0
>
>
> Folloup for LUCENE-3463.
> TODO:
> - Move test-methods that need the new @UseNoMemoryExpensiveCodec annotation
> to separate classes
> - Eliminate the assumeFalse-calls that check the current codec and disable
> the test if SimpleText or Memory is used
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
