[ 
https://issues.apache.org/jira/browse/LUCENE-3493?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13122011#comment-13122011
 ] 

Mark Miller commented on LUCENE-3493:
-------------------------------------

I have a couple questions:

If the bug is in Lucene, shouldn't we write a test at the Lucene level?

What exactly is the bug? That when you subclass DirectoryReader, it doesn't 
return that subclass from reopen? If this is the desired behavior, isn't it up 
to the subclass to override reopen?

Also, you say the required lucene fix is randomly in the patch, but also that 
you will post another patch showing the lucene fix - I don't see it in the 
patch, so I assume its coming, but the only change I see is making some Lucene 
constructors public - we shouldn't likely do that just for this Solr test I 
think.
                
> Solr reopen on a custom reader doesn't work
> -------------------------------------------
>
>                 Key: LUCENE-3493
>                 URL: https://issues.apache.org/jira/browse/LUCENE-3493
>             Project: Lucene - Java
>          Issue Type: Bug
>          Components: core/index
>    Affects Versions: 3.4
>            Reporter: Jason Rutherglen
>            Priority: Blocker
>         Attachments: LUCENE-3493.patch
>
>
> When a custom index reader is used with Solr and reopen, the custom reader 
> vanishes after the reopen.  It's a bug.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org

Reply via email to