[ 
https://issues.apache.org/jira/browse/LUCENE-3500?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13123543#comment-13123543
 ] 

Simon Willnauer commented on LUCENE-3500:
-----------------------------------------

I am not sure if we can simply remove the ensureOpen() call here. If we close 
the reader and I use it afterwards to get del docs I could see a null value 
which doesn't reflect the actual del docs. Maybe we shouldn't null this out on 
close? I actually wonder if we can make this somehow final together with other 
members?
                
> improve getLiveDocs() performance
> ---------------------------------
>
>                 Key: LUCENE-3500
>                 URL: https://issues.apache.org/jira/browse/LUCENE-3500
>             Project: Lucene - Java
>          Issue Type: Improvement
>            Reporter: Yonik Seeley
>            Priority: Minor
>         Attachments: LUCENE-3500.patch
>
>
> On segmentReader, liveDocs is volatile because they used to be loaded on 
> demand.
> This no longer appears to be the case... liveDocs are always loaded up front.
> This also means that getLiveDocs() can never fail (even after close), and we 
> can remove the ensureOpen call.
> Minor optimizations, but volatile reads still do prevent optimizations across 
> that boundary.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org

Reply via email to