[ 
https://issues.apache.org/jira/browse/LUCENE-3508?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13134786#comment-13134786
 ] 

Uwe Schindler commented on LUCENE-3508:
---------------------------------------

Robert: I agree. I think, I will do this in a separate issue, to get those 
changes first into 3.x (by merging) and then deprecate/remove all this later. 
Do we have other StopFilters and similar classes that have those String[] ctors?

I will also add a javadocs info to the ctor: "This filter does many lookups on 
the dictionary, so it is recommended for optimal performance to add a 
LowercaseFilter *before* this filter and make the CharArraySet passed as 
dictionary case insensitive."

I would like to add this as a hint, as this filter does per term lots of 
lookups in the Set.
                
> Decompounders based on CompoundWordTokenFilterBase cannot be used with custom 
> attributes
> ----------------------------------------------------------------------------------------
>
>                 Key: LUCENE-3508
>                 URL: https://issues.apache.org/jira/browse/LUCENE-3508
>             Project: Lucene - Java
>          Issue Type: Bug
>          Components: modules/analysis
>    Affects Versions: 3.4, 4.0
>            Reporter: Spyros Kapnissis
>            Assignee: Uwe Schindler
>             Fix For: 3.5, 4.0
>
>         Attachments: LUCENE-3508.patch, LUCENE-3508.patch, LUCENE-3508.patch, 
> LUCENE-3508.patch
>
>
> The CompoundWordTokenFilterBase.setToken method will call clearAttributes() 
> and then will reset only the default Token attributes (term, position, flags, 
> etc) resulting in any custom attributes losing their value. Commenting out 
> clearAttributes() seems to do the trick, but will fail the 
> TestCompoundWordTokenFilter tests..

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org

Reply via email to