[
https://issues.apache.org/jira/browse/SOLR-2849?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13138427#comment-13138427
]
Steven Rowe commented on SOLR-2849:
-----------------------------------
bq. I don't feel strongly about lucene-sandbox being optional so I will put it
back to a full-fledged dependency, and then add an exclusion at the Solr level,
in solr-core.
+1
bq. Regarding the servlet-api: Solr-core genuinely has a dependency on the
servlet-api and someone using solr-core had better have it on its class path.
Provided scope is incorrect because it is non-transitive (something new I
learned). It needs to be a normal compile scope at solr-core so that if some
project, (mine) uses solr-core then it gets pulled in. In order for it to not
wind up in the web app, which is sort of a special rule about the servlet-api
in particular, it is redeclared at that pom with provided scope.
Sounds good.
bq. Regarding jetty-jsp: I find the jetty-jsp dependency curious as I'm not
sure exactly why it is depended on; please enlighten me.
The Jasper compiler from the jetty-jsp jar is used to validate Solr's JSP files
in the Ant build in the Solr webapp module's {{test}} target. The Maven build
doesn't perform this validation. The dependency can be removed from the solr
core POM; when I removed the dependency, all tests passed under Maven.
bq. There are two other jetty dependencies; should they all be depended upon in
the same way?
I think the other two, which are required for tests to compile, should remain
{{optional}}, so that they are not transitive.
> Solr maven dependencies: logging
> --------------------------------
>
> Key: SOLR-2849
> URL: https://issues.apache.org/jira/browse/SOLR-2849
> Project: Solr
> Issue Type: Improvement
> Components: Build
> Affects Versions: 4.0
> Reporter: David Smiley
> Priority: Trivial
> Attachments: SOLR-2849_maven_dependencies.patch,
> SOLR-2849_maven_dependencies.patch, SOLR-2849_maven_dependencies.patch
>
>
> I was looking at my maven based project's Solr-core dependencies (trunk), and
> observed some issues that I think should be fixed in Solr's maven poms. I ran
> {{mvn dependency:tree}} -- the output is further below. There are two
> changes I see needed, related to logging:
> * slf4j-jdk14 should be runtime scope, and optional.
> * httpclient depends on commons-logging. Exclude this dependency from the
> httpclient dependency, and add a dependency on jcl-over-slf4j with compile
> scope.
> * Zookeeper depends on Log4j, unfortunately. There is an issue to change this
> to SLF4J: ZOOKEEPER-850. In the mean time we should exclude it and use
> log4j-over-slf4j with compile scope, at the solrj pom.
> As an aside, it's unfortunate to see all those velocity dependencies. It
> even depends on struts -- seriously?! I hope solritas gets put back into a
> contrib sometime: SOLR-2588
> Steve, if you'd like to me to create the patch, I will.
> {code}
> [INFO] +- org.apache.solr:solr-core:jar:4.0-SNAPSHOT:compile
> [INFO] | +- org.apache.solr:solr-solrj:jar:4.0-SNAPSHOT:compile
> [INFO] | | \- org.apache.zookeeper:zookeeper:jar:3.3.3:compile
> [INFO] | | +- log4j:log4j:jar:1.2.15:compile
> [INFO] | | | \- javax.mail:mail:jar:1.4:compile
> [INFO] | | | \- javax.activation:activation:jar:1.1:compile
> [INFO] | | \- jline:jline:jar:0.9.94:compile
> [INFO] | +- org.apache.solr:solr-noggit:jar:4.0-SNAPSHOT:compile
> [INFO] | +-
> org.apache.lucene:lucene-analyzers-phonetic:jar:4.0-SNAPSHOT:compile
> [INFO] | +- org.apache.lucene:lucene-highlighter:jar:4.0-SNAPSHOT:compile
> [INFO] | +- org.apache.lucene:lucene-memory:jar:4.0-SNAPSHOT:compile
> [INFO] | +- org.apache.lucene:lucene-misc:jar:4.0-SNAPSHOT:compile
> [INFO] | +- org.apache.lucene:lucene-queryparser:jar:4.0-SNAPSHOT:compile
> [INFO] | | \- org.apache.lucene:lucene-sandbox:jar:4.0-SNAPSHOT:compile
> [INFO] | | \- jakarta-regexp:jakarta-regexp:jar:1.4:compile
> [INFO] | +- org.apache.lucene:lucene-spatial:jar:4.0-SNAPSHOT:compile
> [INFO] | +- org.apache.lucene:lucene-suggest:jar:4.0-SNAPSHOT:compile
> [INFO] | +- org.apache.lucene:lucene-grouping:jar:4.0-SNAPSHOT:compile
> [INFO] | +- org.apache.solr:solr-commons-csv:jar:4.0-SNAPSHOT:compile
> [INFO] | +- commons-codec:commons-codec:jar:1.4:compile
> [INFO] | +- commons-fileupload:commons-fileupload:jar:1.2.1:compile
> [INFO] | +- commons-httpclient:commons-httpclient:jar:3.1:compile
> [INFO] | | \- commons-logging:commons-logging:jar:1.0.4:compile
> [INFO] | +- commons-io:commons-io:jar:1.4:compile
> [INFO] | +- org.apache.velocity:velocity:jar:1.6.4:compile
> [INFO] | | +- commons-collections:commons-collections:jar:3.2.1:compile
> [INFO] | | \- oro:oro:jar:2.0.8:compile
> [INFO] | +- org.apache.velocity:velocity-tools:jar:2.0:compile
> [INFO] | | +- commons-beanutils:commons-beanutils:jar:1.7.0:compile
> [INFO] | | +- commons-digester:commons-digester:jar:1.8:compile
> [INFO] | | +- commons-chain:commons-chain:jar:1.1:compile
> [INFO] | | +- commons-validator:commons-validator:jar:1.3.1:compile
> [INFO] | | +- dom4j:dom4j:jar:1.1:compile
> [INFO] | | +- sslext:sslext:jar:1.2-0:compile
> [INFO] | | +- org.apache.struts:struts-core:jar:1.3.8:compile
> [INFO] | | | \- antlr:antlr:jar:2.7.2:compile
> [INFO] | | +- org.apache.struts:struts-taglib:jar:1.3.8:compile
> [INFO] | | \- org.apache.struts:struts-tiles:jar:1.3.8:compile
> [INFO] | +- org.slf4j:slf4j-jdk14:jar:1.6.1:compile
> [INFO] | \- org.codehaus.woodstox:wstx-asl:jar:3.2.7:runtime
> {code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
