[ https://issues.apache.org/jira/browse/SOLR-2565?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13141651#comment-13141651 ]
Mark Miller commented on SOLR-2565: ----------------------------------- bq. that test now fails for me due to what looks like a timing issue Two of the tests in hossmans new AutoCommit test where failing for me on my linux box - i tweaked both to pass and also tested them on my mac. I've also reenabled the AutoCommit test class, but removed the tests involving soft commit - they will be tested with this new method in the new test class instead - later we can move the original auto commit test methods to the new style. I'll commit soon. > Prevent IW#close and cut over to IW#commit > ------------------------------------------ > > Key: SOLR-2565 > URL: https://issues.apache.org/jira/browse/SOLR-2565 > Project: Solr > Issue Type: Improvement > Components: update > Affects Versions: 4.0 > Reporter: Simon Willnauer > Assignee: Mark Miller > Fix For: 4.0 > > Attachments: SOLR-2565-revert.patch, SOLR-2565.patch, > SOLR-2565.patch, SOLR-2565.patch, SOLR-2565__HuperDuperAutoCommitTest.patch, > dump.txt, fix+hossmans-test.patch, slowtests.txt > > > Spinnoff from SOLR-2193. We already have a branch to work on this issue here > https://svn.apache.org/repos/asf/lucene/dev/branches/solr2193 > The main goal here is to prevent solr from closing the IW and use IW#commit > instead. AFAIK the main issues here are: > The update handler needs an overhaul. > A few goals I think we might want to look at: > 1. Expose the SolrIndexWriter in the api or add the proper abstractions to > get done what we now do with special casing: > 2. Stop closing the IndexWriter and start using commit (still lazy IW init > though). > 3. Drop iwAccess, iwCommit locks and sync mostly at the Lucene level. > 4. Address the current issues we face because multiple original/'reloaded' > cores can have a different IndexWriter on the same index. > Eventually this is a preparation for NRT support in Solr which I will create > a followup issue for. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org