[
https://issues.apache.org/jira/browse/LUCENE-3552?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13142192#comment-13142192
]
Doron Cohen commented on LUCENE-3552:
-------------------------------------
Shai Patch looks good!
Applies cleanly (after svn mv'ing the two renamed classes) and all facet tests
run.
Only userguide.html still mentions the old classes:
{code}
TaxonomyWriter taxo = new LuceneTaxonomyWriter(taxoDir, OpenMode.CREATE);
..
TaxonomyReader taxo = new LuceneTaxonomyReader(taxoDir);
{code}
Other than that good to go.
> TaxonomyReader/Writer and their Lucene* implementation
> ------------------------------------------------------
>
> Key: LUCENE-3552
> URL: https://issues.apache.org/jira/browse/LUCENE-3552
> Project: Lucene - Java
> Issue Type: Improvement
> Components: modules/facet
> Reporter: Shai Erera
> Assignee: Shai Erera
> Priority: Trivial
> Fix For: 3.5, 4.0
>
> Attachments: LUCENE-3552.patch
>
>
> The facet module contains two interfaces TaxonomyWriter and TaxonomyReader,
> with two implementations Lucene*. We've never actually implemented two
> TaxonomyWriters/Readers, so I'm not sure if these interfaces are useful
> anymore. Therefore I'd like to propose that we do either of the following:
> # Remove the interfaces and remove the Lucene part from the implementation
> classes (to end up with TW/TR impls). Or,
> # Keep the interfaces, but rename the Lucene* impls to Directory*.
> Whatever we do, I'd like to make the impls/interfaces impl also
> TwoPhaseCommit.
> Any preferences?
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
