[ 
https://issues.apache.org/jira/browse/LUCENE-3557?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13143817#comment-13143817
 ] 

Robert Muir edited comment on LUCENE-3557 at 11/4/11 8:10 AM:
--------------------------------------------------------------

Because of applications like solr that rebuild the spellchecker on commit,
I plan to backport this as-is to 3.x (its contrib, we can break the API) to 
remove 
the silent optimization.

                
      was (Author: rcmuir):
    Because of applications like spellchecker that rebuild the spellchecker on 
commit,
I plan to backport this as-is to 3.x (its contrib, we can break the API) to 
remove 
the silent optimization.

                  
> Spellchecker should take IndexWriterConfig... deprecate old methods?
> --------------------------------------------------------------------
>
>                 Key: LUCENE-3557
>                 URL: https://issues.apache.org/jira/browse/LUCENE-3557
>             Project: Lucene - Java
>          Issue Type: Improvement
>            Reporter: Robert Muir
>            Assignee: Robert Muir
>             Fix For: 3.5, 4.0
>
>         Attachments: LUCENE-3557.patch
>
>
> When looking at LUCENE-3490, i realized there was no way to specify the codec 
> for the spellchecker to use.
> It has the following current methods:
> * indexDictionary(Dictionary dict): this causes optimize!
> * indexDictionary(Dictionary dict, int mergeFactory, int ramMB): this causes 
> optimize!
> * indexDictionary(Dictionary dict, int mergeFactor, int ramMB, boolean 
> optimize)
> But no way to specify an IndexwriterConfig. Additionally, I don't like that 
> several of these ctors force an optimize in a tricky way,
> even though it was like this all along.
> So I think we should add indexDictionary(Dictionary dict, IndexWriterConfig 
> config, boolean optimize).
> We should either deprecate all the other ctors in 3.x and nuke in trunk, or 
> at least add warnings to the ones that optimize.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org

Reply via email to