+1 On Thu, Nov 3, 2011 at 7:24 AM, Michael Herndon <[email protected] > wrote:
> +1 > > On Thu, Nov 3, 2011 at 6:19 AM, Stefan Bodewig <[email protected]> wrote: > > > On 2011-11-02, Prescott Nasser wrote: > > > > > http://people.apache.org/~pnasser/Lucene.Net/2.9.4-incubating-RC2/ > > > > As usual, no technical opinion at all, I leave that to others. > > > > Sigs and hashes look good. NOTICE and LICENSE are fine. > > > > RAT is almost happy, we should add license headers to > > > src/contrib/DistributedSearch/LuceneMonitorSetup/LuceneMonitorSetup.vdproj > > and test/contrib/SpellChecker/Contrib.SpellChecker.Test.nunit but these > > are not blockers to me. Two files is not the same as 120 files. > > > > Source distribution and > > > > > http://svn.apache.org/repos/asf/incubator/lucene.net/tags/Lucene.Net_2_9_4_RC2/ > > don't match exactly, the READMEs are different. The one of the source > > distribution says .NET 3.5, the one of the tag says 2.0. No biggy but > > you should adjust the tag IMHO. > > > > Wearing my IPMC heat I don't see any reason to block the release, so +1 > > from me. > > > > Stefan > > >
