[
https://issues.apache.org/jira/browse/LUCENE-3564?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13145225#comment-13145225
]
Shai Erera commented on LUCENE-3564:
------------------------------------
I briefly looked at rollback impl, and found this comment:
{code}
// Keep the same segmentInfos instance but replace all
// of its SegmentInfo instances. This is so the next
// attempt to commit using this instance of IndexWriter
// will always write to a new generation ("write
// once").
{code}
But if this instance of IndexWriter is closed, this comment has no meaning
right? Does it mean that once rollback() didn't close IW?
> rename IndexWriter.rollback to .rollbackAndClose
> ------------------------------------------------
>
> Key: LUCENE-3564
> URL: https://issues.apache.org/jira/browse/LUCENE-3564
> Project: Lucene - Java
> Issue Type: Improvement
> Reporter: Michael McCandless
> Assignee: Michael McCandless
> Fix For: 3.5, 4.0
>
>
> Spinoff from LUCENE-3454, where Shai noticed that rollback is trappy since it
> [unexpected] closes the IW.
> I think we should rename it to rollbackAndClose.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
