[ 
https://issues.apache.org/jira/browse/LUCENE-3150?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Simon Willnauer updated LUCENE-3150:
------------------------------------

    Attachment: LUCENE-3150.patch

here is a first patch for this issue. I integrated another utility into IOUtils 
that checks if we suppress an InterruptException and resets the interrupt bit 
on the thread if so. I also call maybeResetInterrupt throughout the code in 
core where we catch(Throwable) and don't rethrow - its a start....
                
> Wherever we catch & suppress Throwable we should not suppress 
> ThreadInterruptedException
> ----------------------------------------------------------------------------------------
>
>                 Key: LUCENE-3150
>                 URL: https://issues.apache.org/jira/browse/LUCENE-3150
>             Project: Lucene - Java
>          Issue Type: Bug
>            Reporter: Michael McCandless
>            Priority: Minor
>             Fix For: 3.5, 4.0
>
>         Attachments: LUCENE-3150.patch
>
>
> In various places we catch Throwable and suppress it, usually in exception 
> handlers where we want to just throw the first exc we had hit.
> But this is dangerous for a thread interrupt since it means we can swallow & 
> ignore the interrupt.
> We should at least catch the interrupt & restore the interrupt bit, if we 
> can't rethrow it.
> One example is in SegmentInfos where we write the segments.gen file... there 
> are many other examples in SegmentInfos too.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to