[
https://issues.apache.org/jira/browse/LUCENE-3574?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13149667#comment-13149667
]
Shai Erera commented on LUCENE-3574:
------------------------------------
One typo: "nsme" -> "name"
Also, not sure if it's worth it, but perhaps instead of constants like
MIMINUM_JAVA_X we can have a class JavaVersion that follows the same logic we
have in Version and can compare itself to other JavaVersions? Then we can have
constants for JAVA_6 = new JavaVersion(6) and similar for JAVA_7, and another
CURRENT_JAVA_VER that is initialized with the code you wrote. And you can then
compare CURRENT to JAVA_6/7?
Just an idea.
> Add some more constants for newer Java versions to Constants.class, remove
> outdated ones.
> -----------------------------------------------------------------------------------------
>
> Key: LUCENE-3574
> URL: https://issues.apache.org/jira/browse/LUCENE-3574
> Project: Lucene - Java
> Issue Type: New Feature
> Components: core/other
> Reporter: Uwe Schindler
> Assignee: Uwe Schindler
> Fix For: 3.5, 4.0
>
> Attachments: LUCENE-3574-3x.patch
>
>
> Preparation for LUCENE-3235:
> This adds constants to quickly detect Java6 and Java7 to Constants.java. It
> also deprecated and removes the outdated historical Java versions.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
