[ 
https://issues.apache.org/jira/browse/LUCENE-3573?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13149687#comment-13149687
 ] 

Doron Cohen commented on LUCENE-3573:
-------------------------------------

One more thing 
- In approach B, the fact that the taxonomy just grew simply allows an 
optimization (read only the new ordinals), and so it is not a part of the API 
logic, and the only logic is - was the taxonomy modified or not. 
- In approach A, this fact is part of the API logic. 
                
> TaxonomyReader.refresh() is broken, replace its logic with reopen(), 
> following IR.reopen pattern
> ------------------------------------------------------------------------------------------------
>
>                 Key: LUCENE-3573
>                 URL: https://issues.apache.org/jira/browse/LUCENE-3573
>             Project: Lucene - Java
>          Issue Type: Bug
>          Components: modules/facet
>            Reporter: Doron Cohen
>            Assignee: Doron Cohen
>            Priority: Minor
>         Attachments: LUCENE-3573.patch
>
>
> When recreating the taxonomy index, TR's assumption that categories are only 
> added does not hold anymore.
> As result, calling TR.refresh() will be incorrect at best, but usually throw 
> an AIOOBE.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org

Reply via email to