[
https://issues.apache.org/jira/browse/LUCENE-3582?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13153199#comment-13153199
]
Uwe Schindler commented on LUCENE-3582:
---------------------------------------
I have no preference to floatToIntBits or floatToRawIntBits. I just copied the
code from Yoniks method from Solr, my original NumericRangeQuery code donation
back in the past used floatToIntBits. I just said, the behaviour of NaN in
NumericRangeQuery is undefined so there was no reason to support NaN with NRQ
at all. So I dont care. It does affect NRQ, but to fix NRQ correctly, half open
ranges must be modified to end at Positive_infnity, but then NRQ can never
match NaN.
In my opinion, NumericUtils is made for NumericRangeQuery and the raw method is
an intrinsic, we should use it. I would simply not like to fix this.
If we fix it, i have to add some checks in NRQ's ctor, too. So it supports NaN.
> NumericUtils.floatToSortableInt does not sort certain NaN ranges correctly.
> ---------------------------------------------------------------------------
>
> Key: LUCENE-3582
> URL: https://issues.apache.org/jira/browse/LUCENE-3582
> Project: Lucene - Java
> Issue Type: Bug
> Reporter: Dawid Weiss
> Assignee: Uwe Schindler
> Priority: Trivial
> Fix For: 4.0
>
> Attachments: LUCENE-3582.patch
>
>
> The current implementation of floatToSortableInt does not account for
> different NaN ranges which may result in NaNs sorted before -Infinity and
> after +Infinity. The default Java ordering is: all NaNs after Infinity.
> A possible fix is to make all NaNs canonic "quiet NaN" as in:
> {code}
> // Canonicalize NaN ranges. I assume this check will be faster here than
> // (v == v) == false on the FPU? We don't distinguish between different
> // flavors of NaNs here (see http://en.wikipedia.org/wiki/NaN). I guess
> // in Java this doesn't matter much anyway.
> if ((v & 0x7fffffff) > 0x7f800000) {
> // Apply the logic below to a canonical "quiet NaN"
> return 0x7fc00000 ^ 0x80000000;
> }
> {code}
> I don't commit because I don't know how much of the existing stuff relies on
> this (nobody should be keeping different NaNs in their indexes, but who
> knows...).
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
