[ https://issues.apache.org/jira/browse/LUCENE-3590?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13156803#comment-13156803 ]
Robert Muir commented on LUCENE-3590: ------------------------------------- {quote} Make clone() a shallow copy? I don't think we should support shallow copying at all - it's normally not going to be what a user really wants. One can still do a shallow copy by directly setting the members. {quote} No, abusers of the reference API can create a deep copy directly by setting the members. The onus is on abusers to have these extra lines of code, not for correct users of the API. {quote} Is there even any code in Lucene or Solr that creates a shallow copy? {quote} Yes, and its uglier because of the problems above. > minimize bytesref to be a ref to a byte[] > ----------------------------------------- > > Key: LUCENE-3590 > URL: https://issues.apache.org/jira/browse/LUCENE-3590 > Project: Lucene - Java > Issue Type: Bug > Affects Versions: 4.0 > Reporter: Robert Muir > Priority: Blocker > Attachments: LUCENE-3590_copyCtor.patch > > > Setting this as blocker for 4.0, as this class is used in every API there. > Currently this API is a little of a everything, sometimes its like a > stringbuffer, it > does numeric conversions, all kinds of stuff. > We need this to be a ref to a byte[], nothing else. This other stuff can go > somewhere else. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org