[ https://issues.apache.org/jira/browse/LUCENE-3591?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13156827#comment-13156827 ]
Robert Muir commented on LUCENE-3591: ------------------------------------- +1 I think in most cases people that want to do this are happy with ByteArrayDataInput/Output, its reusable and supports the DataInput/Output API completely. So most existing consumers that want to write a long to a bytearray referred by a BytesRef are using these classes. But for DV this is a good solution, removes some 'non-ref' APIs/minimizes our API exposure. > Make BytesRef.copy[Int,Short,Long] package private for DocValues > ---------------------------------------------------------------- > > Key: LUCENE-3591 > URL: https://issues.apache.org/jira/browse/LUCENE-3591 > Project: Lucene - Java > Issue Type: Sub-task > Affects Versions: 4.0 > Reporter: Simon Willnauer > Assignee: Simon Willnauer > Fix For: 4.0 > > Attachments: LUCENE-3591.patch > > > currently the BytesRef.copy[Int,Short,Long] api is only used by > IndexDocValues and it seems it is pretty unique. I think we should move this > into a package private class in o.a.l.i.values we can still open this up if > it is needed by other packages. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org