[ 
https://issues.apache.org/jira/browse/LUCENE-3596?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13157718#comment-13157718
 ] 

Shai Erera commented on LUCENE-3596:
------------------------------------

bq. I will move the call to createIWC into the constructor and modify openIndex 
signature to accept an IWC instead of the open mode

+1. This makes sense.

bq. just javadoc that fact, and fix the test to always create an order 
preserving MP.

I agree. The options are not very appealing and we might work too hard to 
prevent something that will never happen. The root cause of this issue was the 
inability to turn on IW's infoStream (which IMO should be changed to a proper 
logging framework). Besides our tests, I don't think many will override 
createIWC / openIndexWriter for changing other attributes.
                
> DirectoryTaxonomyWriter extensions should be able to set internal index 
> writer config attributes such as info stream
> --------------------------------------------------------------------------------------------------------------------
>
>                 Key: LUCENE-3596
>                 URL: https://issues.apache.org/jira/browse/LUCENE-3596
>             Project: Lucene - Java
>          Issue Type: Improvement
>          Components: modules/facet
>            Reporter: Doron Cohen
>            Assignee: Doron Cohen
>            Priority: Minor
>         Attachments: LUCENE-3596.patch
>
>
> Current protected openIndexWriter(Directory directory, OpenMode openMode) 
> does not provide access to the IWC it creates.
> So extensions must reimplement this method completely in order to set e.f. 
> info stream for the internal index writer.
> This came up in [user question: Taxonomy indexer debug 
> |http://lucene.472066.n3.nabble.com/Taxonomy-indexer-debug-td3533341.html]

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to