[ 
https://issues.apache.org/jira/browse/LUCENE-3630?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Uwe Schindler updated LUCENE-3630:
----------------------------------

    Attachment: LUCENE-3630-addMissingMethod.patch
    
> MultiReader and ParallelReader accidently override doOpenIfChanged(boolean 
> readOnly) with doOpenIfChanged(boolean doClone)
> --------------------------------------------------------------------------------------------------------------------------
>
>                 Key: LUCENE-3630
>                 URL: https://issues.apache.org/jira/browse/LUCENE-3630
>             Project: Lucene - Java
>          Issue Type: Bug
>          Components: core/index
>    Affects Versions: 3.5
>            Reporter: Uwe Schindler
>            Assignee: Uwe Schindler
>             Fix For: 3.6
>
>         Attachments: LUCENE-3630-addMissingMethod.patch, LUCENE-3630.patch
>
>
> I found this during adding deprecations for RW access in LUCENE-3606:
> the base class defines doOpenIfChanged(boolean readOnly), but MultiReader and 
> ParallelReader "override" this method with a signature 
> doOpenIfChanged(doClone) and missing @Override. This makes consumers calling 
> IR.openIfChanged(boolean readOnly) do the wrong thing. Instead they should 
> get UOE like for the other unimplemented doOpenIfChanged methods in MR and PR.
> Easy fix is to rename and hide this internal "reopen" method, like 
> DirectoryReader,...

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org

Reply via email to