On Sun, Dec 11, 2011 at 8:16 AM, Shai Erera <[email protected]> wrote: >> I dunno, I'm not really sure we should encourage adding more reference >> counting to Lucene (I think we should discourage instead!) > > > But we already have (DirectoryTaxonomyReader). Why should we discourage > that?
Because I think we should avoid reference counting in our apis! I understand why its on IR, but i dont think it shoudl spread. > > >> Lets please not do this! > > > Why? Today whoever manages IndexSearcher instances needs to call > s.getIndexReader().incRef()/decRef(). Why not call on IndexSearcher itself? Because indexsearcher is about things like searching and scoring (not opening and closing readers). -- lucidimagination.com --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
