[ https://issues.apache.org/jira/browse/LUCENE-3638?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13167147#comment-13167147 ]
Shai Erera commented on LUCENE-3638: ------------------------------------ bq. The only question is do we need to provide one that does this? Oh, I did not propose that we do it in Lucene, but rather that Peter do it himself (I wrote "how about *you* ..."). I agree we should not cater for all use cases out there. bq. Yes its definitely redundant. But I think this is probably very common? Doesn't matter to me either way though. I don't mind much either. It's just that this sugar method suggests that you have to create a Set<String> on every call, while if we point people to DSFV, people will fins that they can pass String... too. I anyway think that for most apps, this object is probably constructed just once, because usually the list of fields does not change between queries, or at least you will have a handful of those, one per query type. Perhaps if we omit the sugar method, people will think that way, and indeed create the object just once. Dunno, it's your call. If someone ends up committing that method in the context of this issue, I suggest that its subject is renamed accordingly. Otherwise, just close it. > IndexReader.document always return a doc with all the stored fields loaded. > And this can be slow for the indexed document contain huge fields > --------------------------------------------------------------------------------------------------------------------------------------------- > > Key: LUCENE-3638 > URL: https://issues.apache.org/jira/browse/LUCENE-3638 > Project: Lucene - Java > Issue Type: Improvement > Components: core/index, core/search > Affects Versions: 4.0 > Environment: 64bit linux java 1.6 > Reporter: peter chang > Priority: Minor > Labels: patch > Fix For: 4.0 > > Attachments: doc.fields.patch > > > when generating digest for some documents with huge fields, it should be > unnecessary to load the field but just interesting part of the field with the > offset information. but indexreader always return the whole field content. > afterward, the customized storedfieldsreader will got a repeated loading -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org