[ https://issues.apache.org/jira/browse/LUCENE-3646?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13169509#comment-13169509 ]
Michael McCandless commented on LUCENE-3646: -------------------------------------------- +1, looks great. Nice how few places required SlowMR wrapping.... > throw exception for fieldcache on a non-atomic reader > ----------------------------------------------------- > > Key: LUCENE-3646 > URL: https://issues.apache.org/jira/browse/LUCENE-3646 > Project: Lucene - Java > Issue Type: Task > Reporter: Robert Muir > Fix For: 4.0 > > Attachments: LUCENE-3646.patch > > > In Lucene 4.0, we go through a lot of effort to prevent slow uses of > non-atomic readers: > DirectoryReader/MultiReader etc throw exception if you don't try to access > postings or docvalues apis per-segment, etc. > But the biggest trap of all is still too easy to fall into, we don't do the > same for FieldCache. > I think we should throw exception, forcing the user to either change their > code or use a SlowMultiReaderWrapper. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org