All:
Currently, there's this code in ExternalFileField.init
String ftypeS = getArg("valType", args);
if (ftypeS!=null) {
ftype = schema.getFieldTypes().get(ftypeS);
if (ftype==null || !(ftype instanceof FloatField)) {
throw new SolrException(SolrException.ErrorCode.SERVER_ERROR,
"Only float (FloatField) is currently supported as external field
type. got '" + ftypeS + "'");
}
}
Defining an EFF with valType="pfloat" works, but pfloat is old, really
old. Solr throws an error on "float", which is a TrieFloat type. But
now that Trie fields support sortMissingFirst/Last, does it make sense
to allow the "float" type too? I'm guessing here that
sortMissingFirst/Last is why EFFs are restricted this way, but I
haven't really dug into it.
So as a proof-of-concept, I hacked this in to see if it would work and
"it seems to work just fine" (tm) but I didn't want to look any deeper
until I ran it by folks.
if (ftype==null ||
(! (ftype instanceof TrieFloatField) && !(ftype instanceof
FloatField))) {
throw new SolrException(SolrException.ErrorCode.SERVER_ERROR,
"Only float (FloatField) is currently supported as external field
type. got '" + ftypeS + "'");
}
Should I raise a JIRA? And anybody got any cautions about this?
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
