[ 
https://issues.apache.org/jira/browse/SOLR-2950?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13169670#comment-13169670
 ] 

Yonik Seeley commented on SOLR-2950:
------------------------------------

bq. I can't imagine it will really make much difference given the small number 
of items that we typically would expect to be elevated.

The fact that it will be a small number of elevated docs is entirely my point - 
that means that if we do it per segment, that there will normally be *no* 
documents elevated in a specific segment and the hash lookup can be skipped 
(and that would be a sizeable gain for something simple like a term query).  
You're right about small sets - it doesn't matter if the set size is 1 or 10 if 
you do need to do the lookup.
                
> QueryElevationComponent needlessly looks up document ids
> --------------------------------------------------------
>
>                 Key: SOLR-2950
>                 URL: https://issues.apache.org/jira/browse/SOLR-2950
>             Project: Solr
>          Issue Type: Improvement
>            Reporter: Grant Ingersoll
>            Assignee: Grant Ingersoll
>            Priority: Minor
>             Fix For: 3.6, 4.0
>
>         Attachments: SOLR-2950.patch
>
>
> The QueryElevationComponent needlessly instantiates a FieldCache and does 
> look ups in it for every document.  If we flipped things around a bit and got 
> Lucene internal doc ids on inform() we could then simply do a much smaller 
> and faster lookup during the sort.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org

Reply via email to