Anyone have an opinion on the following patch? Seems like we should be
doing this in crash(), surprised though that nothing else hits this?
Index:
lucene/src/test-framework/java/org/apache/lucene/store/MockDirectoryWrapper.java
===================================================================
---
lucene/src/test-framework/java/org/apache/lucene/store/MockDirectoryWrapper.java
(revision
1226613)
+++
lucene/src/test-framework/java/org/apache/lucene/store/MockDirectoryWrapper.java
(working
copy)
@@ -392,7 +392,15 @@
openFilesDeleted.remove(name);
}
}
- delegate.deleteFile(name);
+ if (forced) {
+ try {
+ delegate.deleteFile(name);
+ } catch (FileNotFoundException e) {
+ // if its a forced delete (e.g. from crash(), this is fine,
maybe it was already deleted)
+ }
+ } else {
+ delegate.deleteFile(name);
+ }
}
public synchronized Set<String> getOpenDeletedFiles() {
On Mon, Jan 2, 2012 at 9:56 PM, Apache Jenkins Server
<[email protected]> wrote:
> Build: https://builds.apache.org/job/Lucene-Solr-tests-only-3.x/12017/
>
> 2 tests failed.
> FAILED:
> junit.framework.TestSuite.org.apache.solr.update.processor.SignatureUpdateProcessorFactoryTest
>
> Error Message:
> /usr/home/hudson/hudson-slave/workspace/Lucene-Solr-tests-only-3.x/checkout/solr/build/solr-core/test/4/solrtest-SignatureUpdateProcessorFactoryTest-1325559069257/index/_v.fdx
> (No such file or directory)
>
> Stack Trace:
> java.io.FileNotFoundException:
> /usr/home/hudson/hudson-slave/workspace/Lucene-Solr-tests-only-3.x/checkout/solr/build/solr-core/test/4/solrtest-SignatureUpdateProcessorFactoryTest-1325559069257/index/_v.fdx
> (No such file or directory)
> at java.io.RandomAccessFile.open(Native Method)
> at java.io.RandomAccessFile.<init>(RandomAccessFile.java:233)
> at
> org.apache.lucene.store.SimpleFSDirectory$SimpleFSIndexInput$Descriptor.<init>(SimpleFSDirectory.java:70)
> at
> org.apache.lucene.store.SimpleFSDirectory$SimpleFSIndexInput.<init>(SimpleFSDirectory.java:97)
> at
> org.apache.lucene.store.SimpleFSDirectory.openInput(SimpleFSDirectory.java:57)
> at org.apache.lucene.store.FSDirectory.openInput(FSDirectory.java:345)
> at
> org.apache.lucene.store.MockDirectoryWrapper.crash(MockDirectoryWrapper.java:248)
> at
> org.apache.lucene.store.MockDirectoryWrapper.close(MockDirectoryWrapper.java:559)
> at
> org.apache.solr.SolrTestCaseJ4.closeDirectories(SolrTestCaseJ4.java:82)
> at org.apache.solr.SolrTestCaseJ4.deleteCore(SolrTestCaseJ4.java:290)
> at
> org.apache.solr.SolrTestCaseJ4.afterClassSolrTestCase(SolrTestCaseJ4.java:72)
>
>
> FAILED:
> junit.framework.TestSuite.org.apache.solr.update.processor.SignatureUpdateProcessorFactoryTest
>
> Error Message:
> java.lang.AssertionError: directory of test was not closed, opened from:
> org.apache.solr.core.MockDirectoryFactory.open(MockDirectoryFactory.java:34)
>
> Stack Trace:
> java.lang.RuntimeException: java.lang.AssertionError: directory of test was
> not closed, opened from:
> org.apache.solr.core.MockDirectoryFactory.open(MockDirectoryFactory.java:34)
> at
> org.apache.lucene.util.LuceneTestCase.afterClassLuceneTestCaseJ4(LuceneTestCase.java:310)
> at
> org.apache.lucene.util.LuceneTestCase.checkResourcesAfterClass(LuceneTestCase.java:349)
> at
> org.apache.lucene.util.LuceneTestCase.afterClassLuceneTestCaseJ4(LuceneTestCase.java:278)
>
>
>
>
> Build Log (for compile errors):
> [...truncated 15166 lines...]
>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: [email protected]
> For additional commands, e-mail: [email protected]
>
--
lucidimagination.com
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
