[ 
https://issues.apache.org/jira/browse/SOLR-2999?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13179799#comment-13179799
 ] 

Simon Willnauer commented on SOLR-2999:
---------------------------------------

I am not sure if this is easily fixable. Even with version you can not really 
tell if we just merged two segments into one (background merge) or if we called 
optimize. It seems we have three problems here. 1) we can't really tell if we 
optimized or not 2) we commit and trigger a new searcher even if there is no 
change in the IW 3) Spellchecker relies on somewhat unrelated events to rebuild 

IMO this is totally fu**ed up and we should not rely on any of those events but 
require that a rebuild should be triggered explicitly. What we currently do is 
neither onCommit nor onOptimize we do onNewSearcher which is not what the API 
promises. Fixing the entire thing to do a onCommit / onOptimize would require 
waiting for the searcher to be available which I doubt is going to be easy nor 
worth it.

I think we should make this super explicit and don't rely on any obscure 
events. The user knows when this should be rebuild and I personally would like 
to have an API that does less implicit things.

just my $0.05
                
>  spellcheck-index is rebuilt on commit if optimized
> ---------------------------------------------------
>
>                 Key: SOLR-2999
>                 URL: https://issues.apache.org/jira/browse/SOLR-2999
>             Project: Solr
>          Issue Type: Bug
>          Components: spellchecker
>    Affects Versions: 3.1, 3.2, 3.3, 3.4, 3.5, 4.0
>            Reporter: Oliver Schihin
>            Priority: Minor
>             Fix For: 3.6, 4.0
>
>
> If an empty commit (i.e. without having posted new documents) is issued on an 
> optimized index, the spellcheck-index is rebuilt even though solrconfig 
> defines buildOnOptimize=true, not buildOnCommit=true.
> The problem was discovered on solr 4.0 but seems to happen on 3.x, too. 
> Discussion and further information can be found on the list 
> (http://lucene.472066.n3.nabble.com/spellcheck-index-is-rebuilt-on-commit-tp3626492p3626492.html)

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to