[ 
https://issues.apache.org/jira/browse/SOLR-2191?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13184657#comment-13184657
 ] 

Yonik Seeley commented on SOLR-2191:
------------------------------------

bq. I think it's more of a project level problem - we have to decide how we 
want to handle logging and stick with it I think.

There's not much of a choice is there?  Logging early isn't always possible 
since there is a lack of context (for logging and for deciding if it should be 
logged).  Logging last means your missing context for extra debugging info.  I 
guess that leaves us living with logging the same exception multiple times 
(since we don't know if it's already been logged).
                
> Change SolrException cstrs that take Throwable to default to 
> alreadyLogged=false
> --------------------------------------------------------------------------------
>
>                 Key: SOLR-2191
>                 URL: https://issues.apache.org/jira/browse/SOLR-2191
>             Project: Solr
>          Issue Type: Bug
>            Reporter: Mark Miller
>            Assignee: Erick Erickson
>             Fix For: 3.6, 4.0
>
>         Attachments: SOLR-2191.patch
>
>
> Because of misuse, many exceptions are now not logged at all - can be painful 
> when doing dev. I think we should flip this setting and work at removing any 
> double logging - losing logging is worse (and it almost looks like we lose 
> more logging than we would get in double logging) - and bad 
> solrexception/logging patterns are proliferating.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to