[ https://issues.apache.org/jira/browse/SOLR-3054?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13190643#comment-13190643 ]
Tommaso Teofili commented on SOLR-3054: --------------------------------------- bq. I looked up the other TokenFilters that filter tokens, unfortunately all of then default to enablePosIncr=false. I am not sure what the right solution is here? Consistency or correctness? in the first patch I went for consistency but then your comment made me realize the enablePosIncr should be true by default. I mean, as a user I'd expect it to be true by default. bq. I would only remove the try-catch blocks in the test methods and let the test method declare the exception. It then gets reported by JUnit with a failure automatically. ok bq. The question is, the wordset is initialized to be empty if missing. Does it make sense? I would maybe make the types file mandatory, as without the filter makes no sense. right, need to fix that > Add a TypeTokenFilterFactory > ---------------------------- > > Key: SOLR-3054 > URL: https://issues.apache.org/jira/browse/SOLR-3054 > Project: Solr > Issue Type: New Feature > Components: Schema and Analysis > Reporter: Tommaso Teofili > Assignee: Uwe Schindler > Fix For: 3.6, 4.0 > > Attachments: SOLR-3054.patch, SOLR-3054_2.patch > > > Create a TypeTokenFilterFactory to make the TypeTokenFilter (filtering tokens > depending on token types, see LUCENE-3671) available in Solr too. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org