[ https://issues.apache.org/jira/browse/LUCENE-3714?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13193637#comment-13193637 ]
Dawid Weiss commented on LUCENE-3714: ------------------------------------- Didn't look at the patch yet but this looks surprising: {noformat} FSTCompletionLookup queries: 50001, time[ms]: 163 [+- 13.04], ~qps: 307 WFSTCompletionLookup queries: 50001, time[ms]: 55 [+- 1.50], ~qps: 910 {noformat} Why would the previous version be so much slower? With onlyMorePopular=true this should be a single pass. Unless it's setup to bring exact match to the top and then there's a need to check multiple buckets with lower scores -- would that be it? > add suggester that uses shortest path/wFST instead of buckets > ------------------------------------------------------------- > > Key: LUCENE-3714 > URL: https://issues.apache.org/jira/browse/LUCENE-3714 > Project: Lucene - Java > Issue Type: New Feature > Components: modules/spellchecker > Reporter: Robert Muir > Attachments: LUCENE-3714.patch, LUCENE-3714.patch, LUCENE-3714.patch, > TestMe.java, out.png > > > Currently the FST suggester (really an FSA) quantizes weights into buckets > (e.g. single byte) and puts them in front of the word. > This makes it fast, but you lose granularity in your suggestions. > Lately the question was raised, if you build lucene's FST with > positiveintoutputs, does it behave the same as a tropical semiring wFST? > In other words, after completing the word, we instead traverse min(output) at > each node to find the 'shortest path' to the > best suggestion (with the highest score). > This means we wouldnt need to quantize weights at all and it might make some > operations (e.g. adding fuzzy matching etc) a lot easier. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org