[
https://issues.apache.org/jira/browse/LUCENE-3753?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13201356#comment-13201356
]
Steven Rowe edited comment on LUCENE-3753 at 2/6/12 3:59 PM:
-------------------------------------------------------------
bq. Can't say I object to the patch if it has a script to fix old patches
Yes.
bq. will go back to 3x too
That's my plan, yes.
bq. and if it will speed up the build system? (Note: I didn't dig into
LUCENE-3754, but its my impression that it would?)
I don't know. I figured it would be about the same speed, but I'll check to be
sure. (I think {{ant build-contrib}} in {{lucene/}} is the right thing to use
for this.) LUCENE-3754 will speed up the Solr build, since it depends on
lucene-core jar, but a lot (all?) of the Lucene build depends on un-jarred
build outputs, and so won't be affected, AFAIK.
bq. can 'ant test-core' be an alias for 'test' inside lucene/core? And same
with javadocs-core? It might work already in the patch (I didnt test), but I
noticed this trips me up for solr as well... just used to typing it i guess.
I'll add them if they don't already work (not sure).
bq. can we give a heads up to the list first? i know i have a bunch of old
checkouts where if i ran 'svn up' i'd have to deal with a hellacious merge
conflict, but dumping out to a patch, upgrading that patch with the tool, and
then applying that to a new checkout with patch --merge would probably be
easier (I'd only have to deal with the "real" conflicts then)
Yes, I agree a heads-up to the dev list first would be good - I was planning on
giving 24 hours notice before committing.
was (Author: steve_rowe):
bq. Can't say I object to the patch if it has a script to fix old patches
Yes.
bq. will go back to 3x too
That's my plan, yes.
bq. and if it will speed up the build system? (Note: I didn't dig into
LUCENE-3754, but its my impression that it would?)
I don't know. I figured it would be about the same speed, but I'll check to be
sure. (I think {{ant build-contrib}} in {{lucene/}} is the right thing to use
for this.) LUCENE-3754 will speed up the Solr build, since it depends on
lucene-core jar, but a lot (all?) of the Lucene build depends on un-jarred
build outputs, and so won't be affected, AFAIK.
bq. can 'ant test-core' be an alias for 'test' inside lucene/core? And same
with javadocs-core? It might work already in the patch (I didnt test), but I
noticed this trips me up for solr as well... just used to typing it i guess.
I'll add them if they don't already work (not sure).
bq. can we give a heads up to the list first? i know i have a bunch of old
checkouts where if i ran 'svn up' i'd have to deal with a hellacious merge
conflict, but dumping out to a patch, upgrading that patch with the tool,
and then applying that to a new checkout with patch --merge would probably be
easier (I'd only have to deal with the "real" conflicts then)
Yes, I agree a heads-up to the dev list first would be good - I was planning on
giving 24 hours notice before committing.
> Restructure the Lucene build system
> -----------------------------------
>
> Key: LUCENE-3753
> URL: https://issues.apache.org/jira/browse/LUCENE-3753
> Project: Lucene - Java
> Issue Type: Improvement
> Components: general/build
> Affects Versions: 3.6, 4.0
> Reporter: Steven Rowe
> Assignee: Steven Rowe
> Attachments: LUCENE-3753.patch
>
>
> Split out separate core/, test-framework/, and tools/ modules, each with its
> own build.xml, under the lucene/ directory, similar to the Solr restructuring
> done in SOLR-2452.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
