[
https://issues.apache.org/jira/browse/SOLR-3109?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13203990#comment-13203990
]
Martijn van Groningen edited comment on SOLR-3109 at 2/8/12 10:25 PM:
----------------------------------------------------------------------
I noticed that the distributed test failed with this patch. After some digging
I found out that the TopGroupsShardResponseProcessor can't really deal with
multiple ShardRequests... I've updated the patch so that only one ShardRequest
is created by the TopGroupsShardRequestFactory. Test passes now and I don't see
any redundant real http requests being generated.
Russell can you confirm this as well?
was (Author: martijn.v.groningen):
I noticed that the distributed test failed with this patch. After some
digging I found out that the TopGroupsShardResponseProcessor can't really deal
with multiple ShardRequests... I've updated the patch so that only ShardRequest
is created by the TopGroupsShardRequestFactory. Test passes now and I don't see
any redundant real http requests being generated.
Russell can you confirm this as well?
> group=true requests result in numerous redundant shard requests
> ---------------------------------------------------------------
>
> Key: SOLR-3109
> URL: https://issues.apache.org/jira/browse/SOLR-3109
> Project: Solr
> Issue Type: Bug
> Components: search
> Affects Versions: 3.5, 4.0
> Environment: 64-bit Linux, sharded environment
> Reporter: Russell Black
> Assignee: Martijn van Groningen
> Priority: Critical
> Labels: patch, performance
> Attachments: SOLR-3109.patch, SOLR-3109.patch
>
>
> During the second phase of a group query, the collator sends a query to each
> of the shards. The purpose of this query is for shards to respond with the
> doc ids that match the set of group ids returned from the first phase. The
> problem is that it sends this second query to each shard multiple times.
> Specifically, in an environment with n shards, each shard will be hit with an
> identical query n times during the second phase of query processing,
> resulting in O(_n_ ^2^) performance where _n_ is the number of shards.
> I have traced this bug down to a single line in
> {{TopGroupsShardRequestFactory.java}}, and I am attaching a patch.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
