[ 
https://issues.apache.org/jira/browse/LUCENE-3774?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13206531#comment-13206531
 ] 

Steven Rowe commented on LUCENE-3774:
-------------------------------------

bq. Can you please double check that everything works with Ant 1.7? Weirdly 
enough, I now see no slowdown on execution...

Works for me (from the top level) under Ant 1.7.1.

Under solr, two problems are found:

{noformat}
validate:
     [echo] License check under: C:\cygwin\home\s\svn\lucene\dev\trunk\solr
 [licenses] MISSING NOTICE for the license file:
 [licenses]   
C:\cygwin\home\s\svn\lucene\dev\trunk\solr\contrib\langid\lib\jsonic-LICENSE-ASL.txt
 [licenses]   Expected location below:
 [licenses]   
C:\cygwin\home\s\svn\lucene\dev\trunk\solr\contrib\langid\lib\jsonic-NOTICE.txt
 [licenses] MISSING LICENSE for the following file:
 [licenses]   
C:\cygwin\home\s\svn\lucene\dev\trunk\solr\example\exampledocs\post.jar
{noformat}

*But*: When I run {{ant validate}} from {{lucene/}} or {{modules/}} or 
{{solr/}}, it fails ({{lucene/}} error shown here):

{noformat}
BUILD FAILED
C:\cygwin\home\s\svn\lucene\dev\trunk\lucene\build.xml:178: The following error 
occurred while executing this line:
C:\cygwin\home\s\svn\lucene\dev\trunk\lucene\tools\custom-tasks.xml:22: 
Problem: failed to create task or type licenses
Cause: The name is undefined.
Action: Check the spelling.
Action: Check that any custom tasks/types have been declared.
Action: Check that any <presetdef>/<macrodef> declarations have taken place.
{noformat}

                
> check-legal isn't doing its job
> -------------------------------
>
>                 Key: LUCENE-3774
>                 URL: https://issues.apache.org/jira/browse/LUCENE-3774
>             Project: Lucene - Java
>          Issue Type: Improvement
>          Components: general/build
>    Affects Versions: 3.6, 4.0
>            Reporter: Steven Rowe
>            Assignee: Steven Rowe
>         Attachments: 3774.patch, LUCENE-3774.patch, LUCENE-3774.patch, 
> LUCENE-3774.patch, LUCENE-3774.patch
>
>
> In trunk, the {{check-legal-lucene}} ant target is not checking any 
> {{lucene/contrib/\*\*/lib/}} directories; the {{modules/**/lib/}} directories 
> are not being checked; and {{check-legal-solr}} can't be checking 
> {{solr/example/lib/\*\*/\*.jar}}, because there are currently {{.jar}} files 
> in there that don't have a license.
> These targets are set up to take in a full list of {{lib/}} directories in 
> which to check, but modules move around, and these lists are not being kept 
> up-to-date.
> Instead, {{check-legal-\*}} should run for each module, if the module has a 
> {{lib/}} directory, and it should be specialized for modules that have more 
> than one ({{solr/core/}}) or that have a {{lib/}} directory in a non-standard 
> place ({{lucene/core/}}).

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org

Reply via email to