[ https://issues.apache.org/jira/browse/LUCENE-3789?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13211071#comment-13211071 ]
Uwe Schindler commented on LUCENE-3789: --------------------------------------- Looks fine. I would make the access method final. > Expose FilteredTermsEnum from MTQ > ---------------------------------- > > Key: LUCENE-3789 > URL: https://issues.apache.org/jira/browse/LUCENE-3789 > Project: Lucene - Java > Issue Type: Improvement > Components: core/search > Affects Versions: 3.6, 4.0 > Reporter: Simon Willnauer > Priority: Minor > Fix For: 3.6, 4.0 > > Attachments: LUCENE-3789.patch > > > MTQ#getEnum() is protected and in order to access it you need to be in the > o.a.l.search package. > here is a relevant snipped from the mailing list discussion > {noformat} > getEnum() is protected so it is intended to be called *only* by subclasses > (that's the idea behind protected methods). They are also accessible by other > classes from the same package, but that's more a Java bug than a feature. The > problem with MTQ is that RewriteMethod is a separate *class* and *not a > subclass* of MTQ, so the method cannot be called (it can because of the "java > bug" called from same package). So theoretically it has to be public > otherwise you cannot call getEnum(). > Another cleaner fix would be to add a protected final method to RewriteMethod > that calls this method from MTQ. So anything subclassing RewriteMethod can > get the enum from inside the RewriteMethod class which is the "correct" way > to handle it. Delegating to MTQ is then "internal". > {noformat} -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org