[ https://issues.apache.org/jira/browse/LUCENE-3360?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13214451#comment-13214451 ]
Ryan McKinley commented on LUCENE-3360: --------------------------------------- wow, lots has changed since the last patch! I *think* all the reader/cache refactoring has settled down, so this would be good to get sorted soon. I ran it through the LUCENE-3753.patch.hack.pl but there are enough changes, that it is significant work to resurrect from the patch; it may be more effective to refactor the code. Martijn, you interested in picking this up again? If no, i may give it a try. > Move FieldCache to IndexReader > ------------------------------ > > Key: LUCENE-3360 > URL: https://issues.apache.org/jira/browse/LUCENE-3360 > Project: Lucene - Java > Issue Type: Improvement > Reporter: Martijn van Groningen > Fix For: 3.6, 4.0 > > Attachments: LUCENE-3360-3x.patch, LUCENE-3360-3x.patch, > LUCENE-3360-3x.patch, LUCENE-3360.patch, LUCENE-3360.patch, > LUCENE-3360.patch, LUCENE-3360.patch, LUCENE-3360.patch, LUCENE-3360.patch, > LUCENE-3360.patch > > > Move the static FieldCache.DEFAULT field instance to atomic IndexReaders, so > that FieldCache insanity caused by the WeakHashMap no longer occurs. > * Add a new method to IndexReader that by default throws an UOE: > {code}public FieldCache getFieldCache(){code} > * The SegmentReader implements this method and returns its own internal > FieldCache implementation. This implementation just uses a > HashMap<Entry<T>,Object>> to store entries. > * The SlowMultiReaderWrapper implements this method as well and basically > behaves the same as the current FieldCacheImpl. > This issue won't solve the insanity that comes from inconsistent usage of a > single field (for example retrieve both int[] and DocTermIndex for the same > field). -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org